From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kangjie Lu <kjlu@umn.edu>, Mark Brown <broonie@kernel.org>
Subject: [PATCH 5/7] Revert "regulator: tps65910: fix a missing check of return value"
Date: Thu, 29 Apr 2021 15:08:09 +0200 [thread overview]
Message-ID: <20210429130811.3353369-6-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20210429130811.3353369-1-gregkh@linuxfoundation.org>
This reverts commit cd07e3701fa6a4c68f8493ee1d12caa18d46ec6a.
Commits from @umn.edu addresses have been found to be submitted in "bad
faith" to try to test the kernel community's ability to review "known
malicious" changes. The result of these submissions can be found in a
paper submitted to the 42nd IEEE Symposium on Security and Privacy
entitled, "Open Source Insecurity: Stealthily Introducing
Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
of Minnesota) and Kangjie Lu (University of Minnesota) but later
withdrawn.
Because of this, all submissions from this group must be reverted from
the kernel tree and will need to be re-reviewed again to determine if
they actually are a valid fix. Until that work is complete, remove this
change to ensure that no problems are being introduced into the
codebase.
Cc: Kangjie Lu <kjlu@umn.edu>
Cc: Mark Brown <broonie@kernel.org>
---
drivers/regulator/tps65910-regulator.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index 1d5b0a1b86f7..8ad1ecc1559f 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -1098,10 +1098,8 @@ static int tps65910_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, pmic);
/* Give control of all register to control port */
- err = regmap_set_bits(pmic->mfd->regmap, TPS65910_DEVCTRL,
+ regmap_set_bits(pmic->mfd->regmap, TPS65910_DEVCTRL,
DEVCTRL_SR_CTL_I2C_SEL_MASK);
- if (err < 0)
- return err;
switch (tps65910_chip_id(tps65910)) {
case TPS65910:
--
2.31.1
next prev parent reply other threads:[~2021-04-29 13:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 13:08 [PATCH 0/7] Second set of revertion of all of the umn.edu commits Greg Kroah-Hartman
2021-04-29 13:08 ` [PATCH 1/7] Revert "rocker: fix incorrect error handling in dma_rings_init" Greg Kroah-Hartman
2021-04-29 13:54 ` Greg Kroah-Hartman
2021-04-29 19:30 ` Pavel Machek
2021-04-29 13:08 ` [PATCH 2/7] Revert "rtc: mc13xxx: fix a double-unlock issue" Greg Kroah-Hartman
2021-04-29 13:52 ` Greg Kroah-Hartman
2021-04-29 13:08 ` [PATCH 3/7] Revert "orinoco: avoid assertion in case of NULL pointer" Greg Kroah-Hartman
2021-04-29 13:50 ` Greg Kroah-Hartman
2021-04-29 13:08 ` [PATCH 4/7] Revert "ethtool: fix a potential missing-check bug" Greg Kroah-Hartman
2021-04-29 13:48 ` Greg Kroah-Hartman
2021-04-29 13:08 ` Greg Kroah-Hartman [this message]
2021-04-29 13:47 ` [PATCH 5/7] Revert "regulator: tps65910: fix a missing check of return value" Greg Kroah-Hartman
2021-04-29 13:08 ` [PATCH 6/7] Revert "leds: lp5523: fix a missing check of return value of lp55xx_read" Greg Kroah-Hartman
2021-04-29 13:44 ` Greg Kroah-Hartman
2021-04-29 14:12 ` Greg Kroah-Hartman
2021-04-29 13:08 ` [PATCH 7/7] Revert "serial: max310x: pass return value of spi_register_driver" Greg Kroah-Hartman
2021-04-29 13:41 ` Greg Kroah-Hartman
2021-04-29 14:12 ` Greg Kroah-Hartman
2021-04-29 19:28 ` [PATCH 0/7] Second set of revertion of all of the umn.edu commits Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429130811.3353369-6-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox