From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B20C433ED for ; Thu, 29 Apr 2021 13:09:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED06861424 for ; Thu, 29 Apr 2021 13:09:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238583AbhD2NJs (ORCPT ); Thu, 29 Apr 2021 09:09:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:34466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238957AbhD2NJR (ORCPT ); Thu, 29 Apr 2021 09:09:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 64ED161424; Thu, 29 Apr 2021 13:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619701710; bh=O4r1DamRUf/Vy8ddqu40jrXafGjcmQZQvyTEc5Mja/U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2mkL3NDwvs2pVER2Rk9wsTkwhi4fG/9+0YwHb+9rfSCIZ2VB+mAb7e6Q6wUlNyJuK XF8owMb8DkquslNOj6162F0agd5KvzDGKyuqZtNF8grKgCLJH/Ty8s4TQNeWNHhHxQ S4ADRspDVZsTPfcRrJDS4Uw4e46lAW/PvLRIu7mU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Kangjie Lu , Mark Brown Subject: [PATCH 5/7] Revert "regulator: tps65910: fix a missing check of return value" Date: Thu, 29 Apr 2021 15:08:09 +0200 Message-Id: <20210429130811.3353369-6-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210429130811.3353369-1-gregkh@linuxfoundation.org> References: <20210429130811.3353369-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit cd07e3701fa6a4c68f8493ee1d12caa18d46ec6a. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper submitted to the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota) but later withdrawn. Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Kangjie Lu Cc: Mark Brown --- drivers/regulator/tps65910-regulator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c index 1d5b0a1b86f7..8ad1ecc1559f 100644 --- a/drivers/regulator/tps65910-regulator.c +++ b/drivers/regulator/tps65910-regulator.c @@ -1098,10 +1098,8 @@ static int tps65910_probe(struct platform_device *pdev) platform_set_drvdata(pdev, pmic); /* Give control of all register to control port */ - err = regmap_set_bits(pmic->mfd->regmap, TPS65910_DEVCTRL, + regmap_set_bits(pmic->mfd->regmap, TPS65910_DEVCTRL, DEVCTRL_SR_CTL_I2C_SEL_MASK); - if (err < 0) - return err; switch (tps65910_chip_id(tps65910)) { case TPS65910: -- 2.31.1