Re: [PATCH 6/7] Revert "leds: lp5523: fix a missing check of return value of lp55xx_read"

Greg Kroah-Hartman
2021-04-29T14:12:36Z

On Thu, Apr 29, 2021 at 03:44:52PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 29, 2021 at 03:08:10PM +0200, Greg Kroah-Hartman wrote:
> > This reverts commit 248b57015f35c94d4eae2fdd8c6febf5cd703900.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper submitted to the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota) but later
> > withdrawn.
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: Kangjie Lu <kjlu@umn.edu>
> > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/leds/leds-lp5523.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
> > index fc433e63b1dc..5036d7d5f3d4 100644
> > --- a/drivers/leds/leds-lp5523.c
> > +++ b/drivers/leds/leds-lp5523.c
> > @@ -305,9 +305,7 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip)
> >
> > /* Let the programs run for couple of ms and check the engine status */
> > usleep_range(3000, 6000);
> > - ret = lp55xx_read(chip, LP5523_REG_STATUS, &status);
> > - if (ret)
> > - return ret;
> > + lp55xx_read(chip, LP5523_REG_STATUS, &status);
> > status &= LP5523_ENG_STATUS_MASK;
> >
> > if (status != LP5523_ENG_STATUS_MASK) {
> > --
> > 2.31.1
> >
>
> This looks incorrect to me as lp5523_run_engine() has been called and
> not cleaned up from properly.
>
> I'll keep the revert and fix this up correctly.

I already reviewed this one too, sorry for the noise.

greg k-h