From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF5CC433B4 for ; Thu, 29 Apr 2021 20:23:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F7A0613FF for ; Thu, 29 Apr 2021 20:23:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236916AbhD2UXu (ORCPT ); Thu, 29 Apr 2021 16:23:50 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:53286 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbhD2UXt (ORCPT ); Thu, 29 Apr 2021 16:23:49 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 1702C1C0B9F; Thu, 29 Apr 2021 22:23:02 +0200 (CEST) Date: Thu, 29 Apr 2021 22:23:01 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Kangjie Lu , Daniel Vetter Subject: Re: [PATCH 075/190] Revert "gma/gma500: fix a memory disclosure bug due to uninitialized bytes" Message-ID: <20210429202301.GI31692@amd> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-76-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="STPqjqpCrtky8aYs" Content-Disposition: inline In-Reply-To: <20210421130105.1226686-76-gregkh@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --STPqjqpCrtky8aYs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > drivers/gpu/drm/gma500/cdv_intel_display.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm= /gma500/cdv_intel_display.c > index 5d3302249779..f89c2088dc2d 100644 > --- a/drivers/gpu/drm/gma500/cdv_intel_display.c > +++ b/drivers/gpu/drm/gma500/cdv_intel_display.c > @@ -405,8 +405,6 @@ static bool cdv_intel_find_dp_pll(const struct gma_li= mit_t *limit, > struct gma_crtc *gma_crtc =3D to_gma_crtc(crtc); > struct gma_clock_t clock; > =20 > - memset(&clock, 0, sizeof(clock)); > - > switch (refclk) { > case 27000: > if (target < 200000) { Original description is correct, we are returning with .vco and .dot unitialized which is at least very very ugly, so we should keep the memset and not revert this. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --STPqjqpCrtky8aYs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmCLFaUACgkQMOfwapXb+vIY8wCglHWfV91ODxkJrVxpHNYGcHBp dUkAoJV/6kLn1j/p0l4KlyXYFMdBIrEK =V7Ne -----END PGP SIGNATURE----- --STPqjqpCrtky8aYs--