From: Peter Enderborg <peter.enderborg@sony.com>
To: <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Michel Lespinasse <walken@google.com>,
Jann Horn <jannh@google.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Minchan Kim <minchan@kernel.org>
Cc: Peter Enderborg <peter.enderborg@sony.com>
Subject: [PATCH 2/2] tracing: Align task.h to use __assing_str for strings.
Date: Fri, 30 Apr 2021 16:22:23 +0200 [thread overview]
Message-ID: <20210430142223.25500-3-peter.enderborg@sony.com> (raw)
In-Reply-To: <20210430142223.25500-1-peter.enderborg@sony.com>
This moves the comm strings to use the tracing string functions
instead of char arrays so they all work in the same way.
Signed-off-by: Peter Enderborg <peter.enderborg@sony.com>
---
include/trace/events/task.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/trace/events/task.h b/include/trace/events/task.h
index 2e977d2935e1..2bd314e60cb6 100644
--- a/include/trace/events/task.h
+++ b/include/trace/events/task.h
@@ -14,20 +14,20 @@ TRACE_EVENT(task_newtask,
TP_STRUCT__entry(
__field( pid_t, pid)
- __array( char, comm, TASK_COMM_LEN)
+ __string(comm, task->comm)
__field( unsigned long, clone_flags)
__field( short, oom_score_adj)
),
TP_fast_assign(
__entry->pid = task->pid;
- memcpy(__entry->comm, task->comm, TASK_COMM_LEN);
+ __assign_str(comm, task->comm);
__entry->clone_flags = clone_flags;
__entry->oom_score_adj = task->signal->oom_score_adj;
),
TP_printk("pid=%d comm=%s clone_flags=%lx oom_score_adj=%hd",
- __entry->pid, __entry->comm,
+ __entry->pid, __get_str(comm),
__entry->clone_flags, __entry->oom_score_adj)
);
@@ -39,21 +39,21 @@ TRACE_EVENT(task_rename,
TP_STRUCT__entry(
__field( pid_t, pid)
- __array( char, oldcomm, TASK_COMM_LEN)
- __array( char, newcomm, TASK_COMM_LEN)
+ __string(oldcomm, task->comm)
+ __string(newcomm, comm)
__field( short, oom_score_adj)
),
TP_fast_assign(
__entry->pid = task->pid;
- memcpy(entry->oldcomm, task->comm, TASK_COMM_LEN);
- strlcpy(entry->newcomm, comm, TASK_COMM_LEN);
+ __assign_str(oldcomm, task->comm);
+ __assign_str(newcomm, comm);
__entry->oom_score_adj = task->signal->oom_score_adj;
),
TP_printk("pid=%d oldcomm=%s newcomm=%s oom_score_adj=%hd",
- __entry->pid, __entry->oldcomm,
- __entry->newcomm, __entry->oom_score_adj)
+ __entry->pid, __get_str(oldcomm),
+ __get_str(newcomm), __entry->oom_score_adj)
);
TRACE_EVENT(task_exit,
--
2.17.1
prev parent reply other threads:[~2021-04-30 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 14:22 [PATCH 0/2] tracing: Add trace for task_exit Peter Enderborg
2021-04-30 14:22 ` [PATCH 1/2] tracing: Add a " Peter Enderborg
2021-04-30 17:48 ` Eric W. Biederman
2021-05-01 9:29 ` Peter.Enderborg
2021-05-01 13:11 ` Steven Rostedt
2021-05-03 13:50 ` Mathieu Desnoyers
2021-05-03 14:48 ` Peter.Enderborg
2021-05-03 16:30 ` Eric W. Biederman
2021-05-03 18:04 ` Peter.Enderborg
2021-05-03 19:02 ` Eric W. Biederman
2021-05-03 19:43 ` Peter.Enderborg
2021-05-03 20:55 ` Steven Rostedt
2021-05-04 8:00 ` Peter.Enderborg
2021-05-04 13:18 ` Steven Rostedt
2021-04-30 14:22 ` Peter Enderborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430142223.25500-3-peter.enderborg@sony.com \
--to=peter.enderborg@sony.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=christophe.leroy@c-s.fr \
--cc=dave@stgolabs.net \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox