Re: [PATCH v4 07/11] powerpc/pseries/iommu: Reorganize iommu_table_setparms*() with new helper

Leonardo Brás
2021-07-13T04:46:56Z

Hello Alexey,

On Fri, 2021-06-18 at 19:26 -0300, Leonardo Brás wrote:
> >
> > > +                                        unsigned long liobn,
> > > unsigned long win_addr,
> > > +                                        unsigned long
> > > window_size,
> > > unsigned long page_shift,
> > > +                                        unsigned long base,
> > > struct
> > > iommu_table_ops *table_ops)
> >
> >
> > iommu_table_setparms() rather than passing 0 around.
> >
> > The same comment about "liobn" - set it in
> > iommu_table_setparms_lpar().
> > The reviewer will see what field atters in what situation imho.
> >
>
> The idea here was to keep all tbl parameters setting in
> _iommu_table_setparms (or iommu_table_setparms_common).
>
> I understand the idea that each one of those is optional in the other
> case, but should we keep whatever value is present in the other
> variable (not zeroing the other variable), or do someting like:
>
> tbl->it_index = 0;
> tbl->it_base = basep;
> (in iommu_table_setparms)
>
> tbl->it_index = liobn;
> tbl->it_base = 0;
> (in iommu_table_setparms_lpar)
>

This one is supposed to be a question, but I missed the question mark.
Sorry about that.

I would like to get your opinion in this :)