From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FD7C433B4 for ; Sun, 2 May 2021 06:38:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABC4A61476 for ; Sun, 2 May 2021 06:38:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbhEBGjo (ORCPT ); Sun, 2 May 2021 02:39:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:36038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbhEBGjm (ORCPT ); Sun, 2 May 2021 02:39:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9679861476 for ; Sun, 2 May 2021 06:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619937531; bh=kQttLTIIUCicm1iRyu3syeryFv//zpkTRfVaZ7LXNwk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=RBByShyeaUjUtVP5CTfy/bBN9hJBE+bMzT/+pt+ZqRDV1sQCBEGBdaLycTQDe0GqA U7R5ucwLooV2vRJ0st3ujA7U4OMsqFCB/R2iFkTU4UWc11a9EUR0PuTRmrqZwxGb+Q 4OEkCih94Cdlrm2gdsC+jBfoJ2Em4J6GTqvlcOEEx5Uri3unogS1GfA1Uy0mQ2lc9/ LGkfJHUIRTisiidLCDDPV8AHd96RO1EFLZpGucNvw/vkG06mFoCPYDRWHTLSXQeLqh uZXGMZzXecirKisy3G/Ucv6V/EvV8YKT6WvztvZUeDZZ11FIdtJw9aP3Iy1obj56rx QSfCzvmPY89gQ== From: Oded Gabbay To: linux-kernel@vger.kernel.org Subject: [PATCH 2/4] habanalabs: use dev_dbg upon hint address failure Date: Sun, 2 May 2021 09:38:43 +0300 Message-Id: <20210502063845.4615-2-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210502063845.4615-1-ogabbay@kernel.org> References: <20210502063845.4615-1-ogabbay@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hint address failure that results in a valid mapping with an address that was allocated by the driver is not a real failure. Therefore, the driver shouldn't notify about this in kernel log. The user is responsible to check the returned address. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/memory.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c index b92878d76f23..43924e1c0315 100644 --- a/drivers/misc/habanalabs/common/memory.c +++ b/drivers/misc/habanalabs/common/memory.c @@ -570,8 +570,10 @@ static u64 get_va_block(struct hl_device *hdev, if ((is_align_pow_2 && (hint_addr & (va_block_align - 1))) || (!is_align_pow_2 && do_div(tmp_hint_addr, va_range->page_size))) { - dev_info(hdev->dev, "Hint address 0x%llx will be ignored\n", - hint_addr); + + dev_dbg(hdev->dev, + "Hint address 0x%llx will be ignored because it is not aligned\n", + hint_addr); hint_addr = 0; } -- 2.25.1