* [PATCH] virtio_ring: boolean values to a bool variable
@ 2021-01-15 10:00 Jiapeng Zhong
2021-01-18 2:57 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Zhong @ 2021-01-15 10:00 UTC (permalink / raw)
To: mst; +Cc: jasowang, virtualization, linux-kernel, Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/virtio/virtio_ring.c:1637:1-29: WARNING: Assignment of
0/1 to bool variable.
./drivers/virtio/virtio_ring.c:1636:1-30: WARNING: Assignment of
0/1 to bool variable.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
drivers/virtio/virtio_ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 71e16b5..5adb361 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -1633,8 +1633,8 @@ static struct virtqueue *vring_create_virtqueue_packed(
vq->packed.vring.device = device;
vq->packed.next_avail_idx = 0;
- vq->packed.avail_wrap_counter = 1;
- vq->packed.used_wrap_counter = 1;
+ vq->packed.avail_wrap_counter = true;
+ vq->packed.used_wrap_counter = true;
vq->packed.event_flags_shadow = 0;
vq->packed.avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio_ring: boolean values to a bool variable
2021-01-15 10:00 [PATCH] virtio_ring: boolean values to a bool variable Jiapeng Zhong
@ 2021-01-18 2:57 ` Jason Wang
2021-05-03 8:17 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Jason Wang @ 2021-01-18 2:57 UTC (permalink / raw)
To: Jiapeng Zhong, mst; +Cc: virtualization, linux-kernel
On 2021/1/15 下午6:00, Jiapeng Zhong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/virtio/virtio_ring.c:1637:1-29: WARNING: Assignment of
> 0/1 to bool variable.
>
> ./drivers/virtio/virtio_ring.c:1636:1-30: WARNING: Assignment of
> 0/1 to bool variable.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
It looks to me it's not the only places:
git grep avail_wrap_counter
drivers/virtio/virtio_ring.c: bool avail_wrap_counter;
drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1;
drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1;
drivers/virtio/virtio_ring.c: if (wrap_counter !=
vq->packed.avail_wrap_counter)
drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter = 1;
Thanks
> ---
> drivers/virtio/virtio_ring.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 71e16b5..5adb361 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1633,8 +1633,8 @@ static struct virtqueue *vring_create_virtqueue_packed(
> vq->packed.vring.device = device;
>
> vq->packed.next_avail_idx = 0;
> - vq->packed.avail_wrap_counter = 1;
> - vq->packed.used_wrap_counter = 1;
> + vq->packed.avail_wrap_counter = true;
> + vq->packed.used_wrap_counter = true;
> vq->packed.event_flags_shadow = 0;
> vq->packed.avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio_ring: boolean values to a bool variable
2021-01-18 2:57 ` Jason Wang
@ 2021-05-03 8:17 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2021-05-03 8:17 UTC (permalink / raw)
To: Jason Wang; +Cc: Jiapeng Zhong, virtualization, linux-kernel
On Mon, Jan 18, 2021 at 10:57:03AM +0800, Jason Wang wrote:
>
> On 2021/1/15 下午6:00, Jiapeng Zhong wrote:
> > Fix the following coccicheck warnings:
> >
> > ./drivers/virtio/virtio_ring.c:1637:1-29: WARNING: Assignment of
> > 0/1 to bool variable.
> >
> > ./drivers/virtio/virtio_ring.c:1636:1-30: WARNING: Assignment of
> > 0/1 to bool variable.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
>
>
> It looks to me it's not the only places:
>
> git grep avail_wrap_counter
> drivers/virtio/virtio_ring.c: bool avail_wrap_counter;
> drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1;
> drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1;
> drivers/virtio/virtio_ring.c: if (wrap_counter !=
> vq->packed.avail_wrap_counter)
> drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter = 1;
>
> Thanks
Agreed if we are doing this let's change them all.
>
> > ---
> > drivers/virtio/virtio_ring.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> > index 71e16b5..5adb361 100644
> > --- a/drivers/virtio/virtio_ring.c
> > +++ b/drivers/virtio/virtio_ring.c
> > @@ -1633,8 +1633,8 @@ static struct virtqueue *vring_create_virtqueue_packed(
> > vq->packed.vring.device = device;
> > vq->packed.next_avail_idx = 0;
> > - vq->packed.avail_wrap_counter = 1;
> > - vq->packed.used_wrap_counter = 1;
> > + vq->packed.avail_wrap_counter = true;
> > + vq->packed.used_wrap_counter = true;
> > vq->packed.event_flags_shadow = 0;
> > vq->packed.avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-03 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-15 10:00 [PATCH] virtio_ring: boolean values to a bool variable Jiapeng Zhong
2021-01-18 2:57 ` Jason Wang
2021-05-03 8:17 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox