Re: [PATCH 50/69] Revert "dmaengine: qcom_hidma: Check for driver register failure"

Sinan Kaya
2021-05-03T12:57:17Z

On 5/3/2021 7:57 AM, Greg Kroah-Hartman wrote:
> This reverts commit a474b3f0428d6b02a538aa10b3c3b722751cb382.
>
> Because of recent interactions with developers from @umn.edu, all
> commits from them have been recently re-reviewed to ensure if they were
> correct or not.
>
> Upon review, this commit was found to be incorrect for the reasons
> below, so it must be reverted. It will be fixed up "correctly" in a
> later kernel change.
>
> The original change is NOT correct, as it does not correctly unwind from
> the resources that was allocated before the call to
> platform_driver_register().
>
> Cc: Aditya Pakki <pakki001@umn.edu>
> Cc: Sinan Kaya <okaya@kernel.org>
> Cc: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/dma/qcom/hidma_mgmt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
> index 806ca02c52d7..fe87b01f7a4e 100644
> --- a/drivers/dma/qcom/hidma_mgmt.c
> +++ b/drivers/dma/qcom/hidma_mgmt.c
> @@ -418,8 +418,9 @@ static int __init hidma_mgmt_init(void)
> hidma_mgmt_of_populate_channels(child);
> }
> #endif
> - return platform_driver_register(&hidma_mgmt_driver);
> + platform_driver_register(&hidma_mgmt_driver);
>
> + return 0;
> }
> module_init(hidma_mgmt_init);
> MODULE_LICENSE("GPL v2");
>

Acked-By: Sinan Kaya <okaya@kernel.org>