From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme-multipath: Reset bi_disk to ns head when failover
Date: Mon, 3 May 2021 17:53:45 +0200 [thread overview]
Message-ID: <20210503155345.GA5342@lst.de> (raw)
In-Reply-To: <20210503125741.68117-1-dwagner@suse.de>
On Mon, May 03, 2021 at 02:57:41PM +0200, Daniel Wagner wrote:
> The path can be stale when we failover. If we don't reset the bdev to
> the ns head and the I/O finally completes in end_io() it will triggers
> a crash. By resetting the to ns head disk so that the submit path can
> map the request to an active path.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>
> The patch is against nvme-5.13.
There is no bi_disk in nvme-5.13, but fortunately that slipped in only
in the subject.
> + bdev = bdget_disk(ns->head->disk, 0);
Please just use ns->head->disk->part0 directly. No need for the
reference and bdget_disk is about to go away.
next prev parent reply other threads:[~2021-05-03 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 12:57 [PATCH] nvme-multipath: Reset bi_disk to ns head when failover Daniel Wagner
2021-05-03 13:33 ` Hannes Reinecke
2021-05-03 15:53 ` Christoph Hellwig [this message]
2021-05-03 16:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503155345.GA5342@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox