From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B27C43460 for ; Mon, 3 May 2021 17:42:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C250610E9 for ; Mon, 3 May 2021 17:42:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231639AbhECRnh (ORCPT ); Mon, 3 May 2021 13:43:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231513AbhECRnf (ORCPT ); Mon, 3 May 2021 13:43:35 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A087C06174A for ; Mon, 3 May 2021 10:42:41 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id ge1so3554790pjb.2 for ; Mon, 03 May 2021 10:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YwS8hQU33H1/ZeBZdRBG9ZJ/sKIODEM23v4su4rhiCc=; b=dIevIsu+BecbCDIM9vCBTdsPIaXduatZL5c7A0AoUn5fKQ0NyNS3wvgxnmo+3iz1OB bv9uA4L1dDIlulUeRitvUnI+TG+9ndoRh1q3j5wywyfDcEg2EMWAZCsAkUZ0sktXgrMw gLDSgKJDMfHs6Y8JvuewH3RIv/4xjjbFKC1o3m7Nf5gEc0Qx5+78Ah6pO26iiV1NN/J6 OwWCCVIFiE9wze5yMp5o769ro4M3+RI9gb9VTi/vesW1Ao2Dk/Qzd6cVttXI8yV1FpVu rd3DqiPKVvl9S3tNnIB4SjimSDxqyksXs8kqfHXp9AcQnXzjzH4KTvAX0gFJyATFhjC0 yHQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YwS8hQU33H1/ZeBZdRBG9ZJ/sKIODEM23v4su4rhiCc=; b=HxTaVgskulUSqDBGuvp+ST51gXwpfWLdN9aSh5QAYGTzenKiGSVORXOdRMTWj7G2GB cVtuKliI67dmu8qtO+WExDtnWfoqDLyEndon6Fgmb+5KnSB2cesLusUYCJFAy+0BYNOi l8dRr42wTbKjPYPvJq5RgbCfgeMM3+XmaVJl1SMERk/R4cQWL8yVVwkk9CVL93gUzgRu mlD3beA4wyf79NiB47PEfoGZHS/tvvvgI1NsNWx7ByZc6Lle1Zxk0Gqf/5JuXsfCMndj mkxxQ7tg41AMFcpxtN+9nGgtw8EPrMgr9PhE6Tf9xiKWJQQe4MijZU5YVX5refNq7v/j o2uQ== X-Gm-Message-State: AOAM530TS98ZKCtky7KS1PJ4LDThY9PGKGv/QJhvexEPzYP0nGjbh9xU 2aUgtWiGKnkirOcYtw8ZY1c8zKFwMEGQ3Q== X-Google-Smtp-Source: ABdhPJzTQEVa1Em9j/IFmpfCNW+75vCOby+/gmN3VVIzRlRGpxwsE43eZzakv3nxEXUiOCvj5fYExg== X-Received: by 2002:a17:90a:9f02:: with SMTP id n2mr16264556pjp.190.1620063761016; Mon, 03 May 2021 10:42:41 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id u20sm194311pgl.27.2021.05.03.10.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 10:42:40 -0700 (PDT) Date: Mon, 3 May 2021 11:42:38 -0600 From: Mathieu Poirier To: Arnaud Pouliquen Cc: Bjorn Andersson , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] rpmsg: char: Remove useless includes Message-ID: <20210503174238.GD1699665@xps15> References: <20210429080639.6379-1-arnaud.pouliquen@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429080639.6379-1-arnaud.pouliquen@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 29, 2021 at 10:06:39AM +0200, Arnaud Pouliquen wrote: > Remove includes that are not requested to build the module. > > Signed-off-by: Arnaud Pouliquen > --- > applied without issue on Bjorn next branch (dc0e14fa833b) > --- > drivers/rpmsg/rpmsg_char.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > index 2bebc9b2d163..e4e54f515af6 100644 > --- a/drivers/rpmsg/rpmsg_char.c > +++ b/drivers/rpmsg/rpmsg_char.c > @@ -10,19 +10,10 @@ > * was based on TI & Google OMX rpmsg driver. > */ > #include > -#include This is where the declaration for struct device is along with other goodies like get/put_device(). > -#include That is where struct file is declared. > -#include This is where you get ida_simple_get() and ida_simple_remove() from. > #include > #include > -#include This is where struct poll_table and poll_wait() comes from. > #include > #include > -#include This gives you kzalloc() and kfree(). > -#include This gives you copy_from_user(). > -#include This gives you RPMSG_CREATE_EPT_IOCTL and RPMSG_DESTROY_EPT_IOCTL. > - > -#include "rpmsg_internal.h" That one I agree with. Thanks, Mathieu > > #define RPMSG_DEV_MAX (MINORMASK + 1) > > -- > 2.17.1 >