From: Rob Herring <robh@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: frowand.list@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH] of: overlay: Remove redundant assignment to ret
Date: Mon, 3 May 2021 13:57:58 -0500 [thread overview]
Message-ID: <20210503185758.GA2192105@robh.at.kernel.org> (raw)
In-Reply-To: <1619347258-55002-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Sun, 25 Apr 2021 18:40:58 +0800, Jiapeng Chong wrote:
> Variable ret is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> drivers/of/overlay.c:1197:2: warning: Value stored to 'ret' is never
> read [clang-analyzer-deadcode.DeadStores].
>
> drivers/of/overlay.c:1026:2: warning: Value stored to 'ret' is never
> read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/of/overlay.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Applied, thanks!
prev parent reply other threads:[~2021-05-03 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 10:40 [PATCH] of: overlay: Remove redundant assignment to ret Jiapeng Chong
2021-05-03 18:57 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503185758.GA2192105@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox