From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5.11.y, 5.10.y, 5.4.y] vfio: Depend on MMU
Date: Thu, 6 May 2021 18:10:53 -0300 [thread overview]
Message-ID: <20210506211053.GR1370958@nvidia.com> (raw)
In-Reply-To: <162033393037.4094195.18215062546427210332.stgit@omen>
On Thu, May 06, 2021 at 02:47:51PM -0600, Alex Williamson wrote:
> From: Jason Gunthorpe <jgg@nvidia.com>
>
> commit b2b12db53507bc97d96f6b7cb279e831e5eafb00 upstream
>
> VFIO_IOMMU_TYPE1 does not compile with !MMU:
>
> ../drivers/vfio/vfio_iommu_type1.c: In function 'follow_fault_pfn':
> ../drivers/vfio/vfio_iommu_type1.c:536:22: error: implicit declaration of function 'pte_write'; did you mean 'vfs_write'? [-Werror=implicit-function-declaration]
>
> So require it.
>
> Suggested-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Message-Id: <0-v1-02cb5500df6e+78-vfio_no_mmu_jgg@nvidia.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Cc: stable@vger.kernel.org # 5.11.y, 5.10.y, 5.4.y
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
>
> The noted stable branches include upstream commit 179209fa1270
> ("vfio: IOMMU_API should be selected") without the follow-up commit
> b2b12db53507 ("vfio: Depend on MMU"), which should have included a
> Fixes: tag for the prior commit. Without this latter commit, we're
> susceptible to randconfig failures with !MMU configs. Thanks!
Right. It would also be a fine solution to not include '1792 in any
stable branches either
Jason
next prev parent reply other threads:[~2021-05-06 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 20:47 [PATCH 5.11.y, 5.10.y, 5.4.y] vfio: Depend on MMU Alex Williamson
2021-05-06 21:10 ` Jason Gunthorpe [this message]
2021-05-07 5:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506211053.GR1370958@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox