From: Mark Brown <broonie@kernel.org>
To: Lucas Tanure <tanureal@opensource.cirrus.com>
Cc: James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org,
Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Subject: Re: [PATCH] ASoC: cs42l42: make HSBIAS_SENSE_EN optional
Date: Fri, 7 May 2021 16:38:12 +0100 [thread overview]
Message-ID: <20210507153812.GD6383@sirena.org.uk> (raw)
In-Reply-To: <20210507141748.742037-1-tanureal@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Fri, May 07, 2021 at 03:17:48PM +0100, Lucas Tanure wrote:
> + - cirrus,hs-bias-sense-en: Configures HSBIAS output current sense through
> + the external 2.21-k resistor. HSBIAS_SENSE is hardware feature to reduce
> + the potential pop noise during the headset plug out slowly. But on some
> + platforms ESD voltage will affect it causing test to fail, especially
> + with CTIA headset type. For different hardware setups, a designer might
> + want to tweak default behavior.
> +
> + 0 - disabled
> + 1 - enabled
> + Default = 1
A boolean property would generally be present/absent rather than having
a value...
> + ret = device_property_read_u32(dev, "cirrus,hs-bias-sense-en", &val);
...and read using device_property_read_bool().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-07 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 14:17 [PATCH] ASoC: cs42l42: make HSBIAS_SENSE_EN optional Lucas Tanure
2021-05-07 15:38 ` Mark Brown [this message]
2021-05-07 18:14 ` kernel test robot
2021-05-07 18:17 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-05-11 14:52 Vitaly Rodionov
2021-05-12 17:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507153812.GD6383@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=vitalyr@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox