From: Marcelo Tosatti <mtosatti@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Frederic Weisbecker <frederic@kernel.org>,
Phil Auld <pauld@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH] Revert "isolcpus: Affine unbound kernel threads to housekeeping cpus"
Date: Fri, 7 May 2021 13:57:10 -0300 [thread overview]
Message-ID: <20210507165710.GA429056@fuller.cnet> (raw)
commit 9cc5b8656892a72438ee7deb introduced a new housekeeping flag,
HK_FLAG_KTHREAD, that when enabled sets the CPU affinity for the
kthreadd process (therefore all unbounded kernel threads created
from that point on will use the housekeeping cpumask).
This is not necessary, since its possible to control placement of
kthreadd from userspace:
# taskset -c -p 0 `pgrep kthreadd`
pid 2's current affinity list: 1
pid 2's new affinity list: 0
Unbounded kernel threads started from that point on will inherit
the kthreadd cpumask.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: linux-2.6/include/linux/sched/isolation.h
===================================================================
--- linux-2.6.orig/include/linux/sched/isolation.h
+++ linux-2.6/include/linux/sched/isolation.h
@@ -14,7 +14,6 @@ enum hk_flags {
HK_FLAG_DOMAIN = (1 << 5),
HK_FLAG_WQ = (1 << 6),
HK_FLAG_MANAGED_IRQ = (1 << 7),
- HK_FLAG_KTHREAD = (1 << 8),
};
#ifdef CONFIG_CPU_ISOLATION
Index: linux-2.6/kernel/kthread.c
===================================================================
--- linux-2.6.orig/kernel/kthread.c
+++ linux-2.6/kernel/kthread.c
@@ -27,7 +27,6 @@
#include <linux/ptrace.h>
#include <linux/uaccess.h>
#include <linux/numa.h>
-#include <linux/sched/isolation.h>
#include <trace/events/sched.h>
@@ -405,8 +404,7 @@ struct task_struct *__kthread_create_on_
* The kernel thread should not inherit these properties.
*/
sched_setscheduler_nocheck(task, SCHED_NORMAL, ¶m);
- set_cpus_allowed_ptr(task,
- housekeeping_cpumask(HK_FLAG_KTHREAD));
+ set_cpus_allowed_ptr(task, cpu_possible_mask);
}
kfree(create);
return task;
@@ -655,7 +653,7 @@ int kthreadd(void *unused)
/* Setup a clean context for our children to inherit. */
set_task_comm(tsk, "kthreadd");
ignore_signals(tsk);
- set_cpus_allowed_ptr(tsk, housekeeping_cpumask(HK_FLAG_KTHREAD));
+ set_cpus_allowed_ptr(tsk, cpu_possible_mask);
set_mems_allowed(node_states[N_MEMORY]);
current->flags |= PF_NOFREEZE;
Index: linux-2.6/kernel/sched/isolation.c
===================================================================
--- linux-2.6.orig/kernel/sched/isolation.c
+++ linux-2.6/kernel/sched/isolation.c
@@ -140,8 +140,7 @@ static int __init housekeeping_nohz_full
{
unsigned int flags;
- flags = HK_FLAG_TICK | HK_FLAG_WQ | HK_FLAG_TIMER | HK_FLAG_RCU |
- HK_FLAG_MISC | HK_FLAG_KTHREAD;
+ flags = HK_FLAG_TICK | HK_FLAG_WQ | HK_FLAG_TIMER | HK_FLAG_RCU | HK_FLAG_MISC;
return housekeeping_setup(str, flags);
}
next reply other threads:[~2021-05-07 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 16:57 Marcelo Tosatti [this message]
2021-05-07 20:16 ` [PATCH] Revert "isolcpus: Affine unbound kernel threads to housekeeping cpus" Frederic Weisbecker
2021-05-07 22:09 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507165710.GA429056@fuller.cnet \
--to=mtosatti@redhat.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox