Re: [PATCH 1/2] dt-bindings: pwm: renesas,tpu-pwm: Improve json-schema

Rob Herring
2021-05-07T22:22:07Z

On Fri, May 07, 2021 at 10:25:12AM +0200, Geert Uytterhoeven wrote:
> - Include the general PWM controller schema,
> - Make clocks, power-domains, and resets properties required.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../bindings/pwm/renesas,tpu-pwm.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> index aa9a4570c9068226..3a072ee29815c695 100644
> --- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> @@ -58,8 +58,25 @@ required:
> - compatible
> - reg
> - '#pwm-cells'
> + - clocks
> + - power-domains
>
> -additionalProperties: false
> +allOf:
> + - $ref: pwm.yaml#

This doesn't add any other properties, so you can keep
'additionalProperties: false'.

> +
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,tpu-r8a73a4
> + - renesas,tpu-r8a7740
> + then:
> + required:
> + - resets
> +
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.25.1
>