From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Potapenko <glider@google.com>
Cc: pmladek@suse.com, mingo@kernel.org, bo.he@intel.com,
yanmin_zhang@linux.intel.com, psodagud@quicinc.com,
dvyukov@google.com, elver@google.com,
linux-kernel@vger.kernel.org, ryabinin.a.a@gmail.com,
he@google.com
Subject: Re: [PATCH v2 1/2] printk: introduce dump_stack_lvl()
Date: Sat, 8 May 2021 17:52:50 -0700 [thread overview]
Message-ID: <20210508175250.d28548e312bfae4c8d779e2d@linux-foundation.org> (raw)
In-Reply-To: <20210506105405.3535023-1-glider@google.com>
On Thu, 6 May 2021 12:54:04 +0200 Alexander Potapenko <glider@google.com> wrote:
> dump_stack() is used for many different cases, which may require a log
> level consistent with other kernel messages surrounding the dump_stack()
> call.
> Without that, certain systems that are configured to ignore the default
> level messages will miss stack traces in critical error reports.
>
> This patch introduces dump_stack_lvl() that behaves similarly to
> dump_stack(), but accepts a custom log level.
> The old dump_stack() becomes equal to dump_stack_lvl(KERN_DEFAULT).
>
> A somewhat similar patch has been proposed in 2012:
> https://lore.kernel.org/lkml/1332493269.2359.9.camel@hebo/
> , but wasn't merged.
Um yeah, I dropped the ball on that one, didn't I? I suspect pretty
much all dump_stack() callsites should be using this.
prev parent reply other threads:[~2021-05-09 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 10:54 [PATCH v2 1/2] printk: introduce dump_stack_lvl() Alexander Potapenko
2021-05-06 10:54 ` [PATCH v2 2/2] kasan: use dump_stack_lvl(KERN_ERR) to print stacks Alexander Potapenko
2021-05-06 11:11 ` Marco Elver
2021-05-06 11:10 ` [PATCH v2 1/2] printk: introduce dump_stack_lvl() Marco Elver
2021-05-09 0:52 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210508175250.d28548e312bfae4c8d779e2d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bo.he@intel.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=he@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pmladek@suse.com \
--cc=psodagud@quicinc.com \
--cc=ryabinin.a.a@gmail.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox