Re: [PATCH] arm64: configs: remove redundant CONFIG_MTK_PMIC_WRAP

Enric Balletbo i Serra
2021-05-11T20:04:49Z

Hi Catalin,

Thanks for cc'ing me.

On 11/5/21 19:20, Catalin Marinas wrote:
> On Sat, May 08, 2021 at 02:24:10AM +0800, Luo Longjun wrote:
>> When I compile kernel in ARM64, it produces the following output:
>>
>> *** Default configuration is based on 'defconfig'
>> arch/arm64/configs/defconfig:1018:warning: override: reassigning to
>> symbol MTK_PMIC_WRAP
>>
>> After checking defcofnig, I found two CONFIG_MTK_PMIC_WRAP options.
>>
>> Signed-off-by: Luo Longjun <luolongjun@huawei.com>
>> ---
>> arch/arm64/configs/defconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 08c6f769df9a..9907a431db0d 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y
>> CONFIG_SPI_SH_MSIOF=m
>> CONFIG_SPI_SUN6I=y
>> CONFIG_SPI_SPIDEV=m
>> -CONFIG_MTK_PMIC_WRAP=m
>> CONFIG_SPMI=y
>> CONFIG_PINCTRL_SINGLE=y
>> CONFIG_PINCTRL_MAX77620=y
>
> Adding Matthias and Enric. This change looks fine to me but I think it
> should go in via the arm-soc tree. Commit 9fd5449e061e introduced the =m
> option while commit fbbe38309d56 introduced the =y variant.
>
> You could add:
>
> Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb")
>

I sent the same patch some time ago [1].

I agree, either land this patch or mine. In any case,

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Matthias is this something that should go through your tree?

Thanks,
Enric

[1]