Re: [PATCH] sata: fsl: fix DPRINTK format string

Jens Axboe
2021-05-17T16:29:29Z

On 5/14/21 3:33 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Printing an __iomem pointer as %x produces a warning:
>
> drivers/ata/sata_fsl.c: In function 'fsl_sata_set_irq_coalescing':
> drivers/ata/sata_fsl.c:316:17: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'void *' [-Werror=format=]
> 316 | DPRINTK("ICC register status: (hcr base: 0x%x) = 0x%x\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 317 | hcr_base, ioread32(hcr_base + ICC));
> | ~~~~~~~~
> | |
> | void *
>
> It's not clear why that pointer should be printed here, but if we do,
> then using %p is the way to avoid the warnings.

Applied, thanks.

--
Jens Axboe