Re: [PATCH] docs: Add more message type documentations for checkpatch

Jonathan Corbet
2021-05-20T20:45:50Z

Dwaipayan Ray <dwaipayanray1@gmail.com> writes:

> (Adding Joe for comments)
>
>> We really shouldn't be linking to outside sites - even kernel.org - when
>> referring to the kernel docs themselves. Just say
>> "Documentation/timers/timers-howto" and let the build system handle the
>> links.
>>
>> There's a lot of these in this file, alas...
>>
>> I've applied this patch since it makes things better overall, but I
>> would really like to see all those URLs go away if possible.
>>
>
> Thanks Jonathan.
>
> Yes it might make things better for the documentation, but again
> since we are using these descriptions in checkpatch's --verbose mode,
> we shall lose the ability to show the links there which I think is currently
> a good addition for the end user.
>
> And I don't think there will be a way to generate these links in checkpatch
> without sphinx's build system....

Ah, OK, I wasn't thinking about that aspect of things; that does change
the situation a bit.

It wouldn't be that hard to do an equivalent of the automarkup magic in
checkpatch to create the relevant links, but I'm not so set on this as
to try to require that. The links can be as they are, sorry for the
noise.

Thanks,

jon