From: Oded Gabbay <ogabbay@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Ohad Sharabi <osharabi@habana.ai>
Subject: [PATCH 3/5] habanalabs: check if asic secured with asic type
Date: Sat, 15 May 2021 19:31:14 +0300 [thread overview]
Message-ID: <20210515163116.14181-3-ogabbay@kernel.org> (raw)
In-Reply-To: <20210515163116.14181-1-ogabbay@kernel.org>
From: Ohad Sharabi <osharabi@habana.ai>
Fix issue in which the input to the function is_asic_secured was device
PCI_IDS number instead of the asic_type enumeration.
Signed-off-by: Ohad Sharabi <osharabi@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
---
drivers/misc/habanalabs/common/habanalabs_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c
index dc92401e7a3f..df1e91f810cc 100644
--- a/drivers/misc/habanalabs/common/habanalabs_drv.c
+++ b/drivers/misc/habanalabs/common/habanalabs_drv.c
@@ -309,7 +309,7 @@ int create_hdev(struct hl_device **dev, struct pci_dev *pdev,
if (pdev)
hdev->asic_prop.fw_security_disabled =
- !is_asic_secured(pdev->device);
+ !is_asic_secured(hdev->asic_type);
else
hdev->asic_prop.fw_security_disabled = true;
--
2.25.1
next prev parent reply other threads:[~2021-05-15 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 16:31 [PATCH 1/5] habanalabs: notify before f/w loading Oded Gabbay
2021-05-15 16:31 ` [PATCH 2/5] habanalabs/gaudi: send hard reset cause to preboot Oded Gabbay
2021-05-15 16:31 ` Oded Gabbay [this message]
2021-05-15 16:31 ` [PATCH 4/5] habanalabs/gaudi: read GIC sts after FW is loaded Oded Gabbay
2021-05-15 16:31 ` [PATCH 5/5] habanalabs/gaudi: do not move HBM bar if iATU done by FW Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210515163116.14181-3-ogabbay@kernel.org \
--to=ogabbay@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osharabi@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox