Re: [RFC PATCH v4 1/2] arm64: Introduce stack trace reliability checks in the unwinder

Madhavan T. Venkataraman
2021-05-25T21:44:47Z

On 5/21/21 12:53 PM, Mark Brown wrote:
> On Fri, May 21, 2021 at 12:47:13PM -0500, Madhavan T. Venkataraman wrote:
>> On 5/21/21 12:42 PM, Mark Brown wrote:
>
>>> Like I say we may come up with some use for the flag in error cases in
>>> future so I'm not opposed to keeping the accounting there.
>
>> So, should I leave it the way it is now? Or should I not set reliable = false
>> for errors? Which one do you prefer?
>
>> Josh,
>
>> Are you OK with not flagging reliable = false for errors in unwind_frame()?
>
> I think it's fine to leave it as it is.
>

OK. I will address the comments so far and send out v5.

Thanks.

Madhavan