From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013CFC433B4 for ; Mon, 17 May 2021 12:29:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCBC56108D for ; Mon, 17 May 2021 12:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237021AbhEQMau (ORCPT ); Mon, 17 May 2021 08:30:50 -0400 Received: from mga03.intel.com ([134.134.136.65]:62855 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231161AbhEQMap (ORCPT ); Mon, 17 May 2021 08:30:45 -0400 IronPort-SDR: wXkMO2ZOKTmNCJvhDnQt1J2C3yJh8h8MC52SbvpOkkKpSoVAgF6BG931JuLuwEq1Kg96L3OrML PHqV3H4WUWRg== X-IronPort-AV: E=McAfee;i="6200,9189,9986"; a="200503830" X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="200503830" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2021 05:29:28 -0700 IronPort-SDR: K800SeI3Oc8FH/odrKivCIdE23HuEchu+xUMuS5WYO/zsOGWxTfkuCcX7sgPXEaHm9gplBf9Le CFY7iVV2OJbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="540520382" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 17 May 2021 05:29:27 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3FF8850E; Mon, 17 May 2021 15:29:48 +0300 (EEST) From: Andy Shevchenko To: Heikki Krogerus , Bartosz Golaszewski , Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" Subject: [PATCH v4 3/4] devres: No need to call remove_nodes() when there none present Date: Mon, 17 May 2021 15:29:45 +0300 Message-Id: <20210517122946.53161-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210517122946.53161-1-andriy.shevchenko@linux.intel.com> References: <20210517122946.53161-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a list of devres nodes is empty, no need to call remove_nodes(). Signed-off-by: Andy Shevchenko --- v4: rebased on top of v5.13-rc2 drivers/base/devres.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/base/devres.c b/drivers/base/devres.c index db1f3137fc81..dee48858663f 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -526,6 +526,10 @@ int devres_release_all(struct device *dev) if (WARN_ON(dev->devres_head.next == NULL)) return -ENODEV; + /* Nothing to release if list is empty */ + if (list_empty(&dev->devres_head)) + return 0; + spin_lock_irqsave(&dev->devres_lock, flags); cnt = remove_nodes(dev, dev->devres_head.next, &dev->devres_head, &todo); spin_unlock_irqrestore(&dev->devres_lock, flags); -- 2.30.2