From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFFDC433ED for ; Mon, 17 May 2021 11:26:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F106B61166 for ; Mon, 17 May 2021 11:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236666AbhEQL1R (ORCPT ); Mon, 17 May 2021 07:27:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236642AbhEQL1O (ORCPT ); Mon, 17 May 2021 07:27:14 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E997C061573; Mon, 17 May 2021 04:25:58 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id A102B1F41EB7; Mon, 17 May 2021 12:25:56 +0100 (BST) Date: Mon, 17 May 2021 13:25:51 +0200 From: Boris Brezillon To: Patrice CHOTARD Cc: Mark Brown , Miquel Raynal , Vignesh Raghavendra , , Alexandre Torgue , , , , , Subject: Re: [PATCH v2 1/3] spi: spi-mem: add automatic poll status functions Message-ID: <20210517132551.7dd56a5e@collabora.com> In-Reply-To: References: <20210507131756.17028-1-patrice.chotard@foss.st.com> <20210507131756.17028-2-patrice.chotard@foss.st.com> <20210517094140.53cb643a@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 May 2021 11:24:25 +0200 Patrice CHOTARD wrote: > Hi Boris > > On 5/17/21 9:41 AM, Boris Brezillon wrote: > > On Fri, 7 May 2021 15:17:54 +0200 > > wrote: > > > >> +/** > >> + * spi_mem_poll_status() - Poll memory device status > >> + * @mem: SPI memory device > >> + * @op: the memory operation to execute > >> + * @mask: status bitmask to ckeck > >> + * @match: (status & mask) expected value > >> + * @timeout_ms: timeout in milliseconds > >> + * > >> + * This function send a polling status request to the controller driver > >> + * > >> + * Return: 0 in case of success, -ETIMEDOUT in case of error, > >> + * -EOPNOTSUPP if not supported. > >> + */ > >> +int spi_mem_poll_status(struct spi_mem *mem, > >> + const struct spi_mem_op *op, > >> + u16 mask, u16 match, u16 timeout_ms) > > > > Maybe you should pass a delay_us too, to poll the status at the right > > rate in the SW-based case (can also be used by drivers if they need to > > Ok, i will add a polling_rate_us parameter to poll_status() callback, > even if in STM32 driver case we will not use it, i agree it should be useful > depending of driver's implementation. > > > configure the polling rate). You could also add an initial_delay_us to > > avoid polling the status too early: an erase operation will take longer > > than a write which will take longer than a read. No need to check the > > status just after issuing the command, especially if the polling is > > done in SW. Those 2 arguments should also be passed to the driver. > > Regarding the addition of an initial_delay_us. We got two solution: > - use the same polling rate already used by read_poll_timeout() and > set read_poll_timeout()'s sleep_before_read parameter to true (in our case 20 us > will be used as initial delay and as polling rate). > > - add an udelay(initial_delay_us) or even better usleep_range(initial_delay_us, > initial_delay_us + delta) before calling read_poll_timeout(). > > I imagine you prefer the second solution ? Yep, you might want to use udelay() when the delay is small and usleep_range() otherwise. > > By adding polling_rate_us and initial_delay_us parameters to > spi_mem_poll_status(), it implies to update all spinand_wait() calls for > different operations (reset, read page, write page, erase) with respective > initial_delay_us/polling_rate_us values for spi_mem_poll_status()'s parameters. > > Can you provide adequate initial_delay_us and polling rate_us for each operation type ?. If I refer to the datasheets I have, tBERS (erase) 1ms to 4ms tPROG 300us to 400us tREAD 25us to 100us Let's assume we want to minimize the latency, I'd recommend dividing the min value by 4 for the initial delay, and dividing it by 20 for the poll delay, which gives: ERASE -> initial_delay = 250us, poll_delay = 50us PROG -> initial_delay = 100us, poll_delay = 20us READ -> initial_delay = 6us, poll_delay = 5us Of course, that'd be even better if we were able to extract this information from the NAND ID (or ONFI table), but I guess we can live with those optimistic values in the meantime.