The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: peterz@infradead.org, mingo@redhat.com, will@kernel.org,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] kernel/locking: make __down_common use flags previously saved
Date: Mon, 17 May 2021 23:36:47 +0900	[thread overview]
Message-ID: <20210517143647.GA53990@hyeyoo> (raw)
In-Reply-To: <YJwn7qb3/ekFBWDF@gmail.com>

On Wed, May 12, 2021 at 09:09:34PM +0200, Ingo Molnar wrote:
> Yes, this is intentional, because if we get into __down_common() we have to 
> schedule, so we have to enable interrupts.

when I sent this patch I thought we have to match XXXX_irqsave with
XXXX_irqrestore, but that was my misunderstanding. I'm sorry for sending
patch saying that it's wrong without explicit evidence.

now I know it's wrong so I won't do that again.

thanks,
Hyeonggon

      reply	other threads:[~2021-05-17 16:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 14:28 [PATCH] kernel/locking: make __down_common use flags previously saved Hyeonggon Yoo
2021-05-11  2:23 ` Hyeonggon Yoo
2021-05-12 19:09 ` Ingo Molnar
2021-05-17 14:36   ` Hyeonggon Yoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517143647.GA53990@hyeyoo \
    --to=42.hyeyoo@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox