public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] USB: serial: digi_acceleport: reduce chars_in_buffer over-reporting
Date: Wed, 19 May 2021 11:20:01 +0200	[thread overview]
Message-ID: <20210519092006.9775-2-johan@kernel.org> (raw)
In-Reply-To: <20210519092006.9775-1-johan@kernel.org>

Due to an ancient quirk in n_tty poll implementation, the
digi_acceleport driver has been reporting that its queue contains 256
(WAKEUP_CHARS) characters whenever its write URB is in use.

This has not been necessary since 2003 when the line-discipline started
taking the write room into account so let's return the maximum transfer
size again in order to over-report a little less and incidentally fix
the related debug statement.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/digi_acceleport.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
index 19ee8191647c..a4194b70a6fe 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -1048,8 +1048,7 @@ static unsigned int digi_chars_in_buffer(struct tty_struct *tty)
 	if (priv->dp_write_urb_in_use) {
 		dev_dbg(&port->dev, "digi_chars_in_buffer: port=%d, chars=%d\n",
 			priv->dp_port_num, port->bulk_out_size - 2);
-		/* return(port->bulk_out_size - 2); */
-		return 256;
+		return port->bulk_out_size - 2;
 	} else {
 		dev_dbg(&port->dev, "digi_chars_in_buffer: port=%d, chars=%d\n",
 			priv->dp_port_num, priv->dp_out_buf_len);
-- 
2.26.3


  reply	other threads:[~2021-05-19  9:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19  9:20 [PATCH 0/6] USB: serial: buffer-callback clean ups Johan Hovold
2021-05-19  9:20 ` Johan Hovold [this message]
2021-05-19  9:20 ` [PATCH 2/6] USB: serial: digi_acceleport: add chars_in_buffer locking Johan Hovold
2021-05-19  9:20 ` [PATCH 3/6] USB: serial: io_edgeport: drop buffer-callback sanity checks Johan Hovold
2021-05-19  9:20 ` [PATCH 4/6] USB: serial: mos7720: " Johan Hovold
2021-05-19  9:20 ` [PATCH 5/6] USB: serial: mos7840: drop buffer-callback return-value comments Johan Hovold
2021-05-19  9:20 ` [PATCH 6/6] USB: serial: drop irq-flags initialisations Johan Hovold
2021-05-21 12:22 ` [PATCH 0/6] USB: serial: buffer-callback clean ups Greg Kroah-Hartman
2021-05-21 13:48   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519092006.9775-2-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox