public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: hdegoede@redhat.com, Larry.Finger@lwfinger.net
Cc: gregkh@linuxfoundation.org, johannes@sipsolutions.net,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: staging: rtl8723bs: removal of 5G code
Date: Thu, 20 May 2021 11:29:49 +0200	[thread overview]
Message-ID: <20210520092946.GA1404@agape.jhs> (raw)

Hi all,

I'm stick with removal of 5Ghz code from rtl8723bs wireless card driver
(in staging subsystem).

I think that this task comprehend deletion of all code managing
80Mhz bandwidth and upper bandwidth (160 and 80+80). For the latter
it's simple, there's quite no code (unused enums and obsolete comments).

The former seems to be trickier, there are handlers like this:

        /* 3 Set Reg483 */
        SubChnlNum = phy_GetSecondaryChnl_8723B(Adapter);
        rtw_write8(Adapter, REG_DATA_SC_8723B, SubChnlNum);

phy_GetSecondaryChnl_8723B() contains code like:

        } else if (pHalData->CurrentChannelBW == CHANNEL_WIDTH_40) {
                if (pHalData->nCur40MhzPrimeSC == HAL_PRIME_CHNL_OFFSET_UPPER)
                        SCSettingOf20 = VHT_DATA_SC_20_UPPER_OF_80MHZ;
                else if (pHalData->nCur40MhzPrimeSC == HAL_PRIME_CHNL_OFFSET_LOWER)
                        SCSettingOf20 = VHT_DATA_SC_20_LOWER_OF_80MHZ;
        }

so if we are on a 40M channel some settings involving 80M are made and
the whole is then written on card registers.

May I get rid of the whole? Are there some implications I should be aware of?
Is secondary channel needed if we are on 40M bandwidth?

Thank you in advance,

fabio

             reply	other threads:[~2021-05-20  9:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  9:29 Fabio Aiuto [this message]
2021-05-25 10:07 ` staging: rtl8723bs: removal of 5G code Hans de Goede
2021-05-25 13:40   ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210520092946.GA1404@agape.jhs \
    --to=fabioaiuto83@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox