From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B1AC433ED for ; Thu, 20 May 2021 16:07:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35AFE61244 for ; Thu, 20 May 2021 16:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233429AbhETQJM (ORCPT ); Thu, 20 May 2021 12:09:12 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:37511 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231601AbhETQJL (ORCPT ); Thu, 20 May 2021 12:09:11 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 49F5C6000F; Thu, 20 May 2021 16:07:48 +0000 (UTC) Date: Thu, 20 May 2021 18:07:47 +0200 From: Miquel Raynal To: Linus Walleij Cc: Corentin Labbe , Boris Brezillon , Richard Weinberger , Vignesh R , linux-kernel , linux-mtd@lists.infradead.org Subject: Re: [PATCH 2/2] mtd: partitions: redboot: fix style issues Message-ID: <20210520180747.03fd60b8@xps13> In-Reply-To: References: <20210520114851.1274609-1-clabbe@baylibre.com> <20210520114851.1274609-2-clabbe@baylibre.com> <20210520173619.26870bc8@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Walleij wrote on Thu, 20 May 2021 18:00:04 +0200: > On Thu, May 20, 2021 at 5:36 PM Miquel Raynal wrote: > > Linus Walleij wrote on Thu, 20 May 2021 > > 17:24:26 +0200: > > > On Thu, May 20, 2021 at 1:49 PM Corentin Labbe wrote: > > > > > > > This patch fixes easy checkpatch issues. > > > > > > > > Signed-off-by: Corentin Labbe > > > (...) > > > > - uint32_t flash_base; // Address within FLASH of image > > > (...) > > > > + u32 flash_base; // Address within FLASH of image > > > > > > Does checkpatch complain about this? At one point the MTD maintainer > > > disliked the u32/u16/u8 types and explicitly wanted to use the C > > > standard library types, and it's the kind of eccentric maintainer > > > deviations we accommodate for. > > > > I suppose this happened quite some time ago? :) > > > > I've never heard Richard nor Boris complaining about it, nor will I. > > Yes that was a specific David Woodhouse preference. > I'm too old! Don't be sad, the new trend is to be sleek. In the dark I worship variables declaration in a reverse Christmas tree order ;-)