Re: [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough

Masami Hiramatsu
2021-05-20T23:07:21Z

On Thu, 20 May 2021 11:47:13 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> Yeah, I have it cued up too. Can it wait till next week?

Yes, of course. Sorry for interruption.

Thank you!

>
> --Steve
>
>
> On May 20, 2021 10:07:38 AM EDT, Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >Hi Steve,
> >
> >Can you pick at least this fix since it is a critical bug?
> >
> >Thank you,
> >
> >On Thu, 13 May 2021 12:06:33 +0900
> >Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> >> Since the "fallthrough" is defined only in the kernel, building
> >> lib/bootconfig.c as a part of user-space tools causes a build
> >> error.
> >>
> >> Add a dummy fallthrough to avoid the build error.
> >>
> >> Cc: stable@vger.kernel.org
> >> Fixes: 4c1ca831adb1 ("Revert "lib: Revert use of fallthrough
> >pseudo-keyword in lib/"")
> >> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> >> ---
> >> tools/bootconfig/include/linux/bootconfig.h | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/tools/bootconfig/include/linux/bootconfig.h
> >b/tools/bootconfig/include/linux/bootconfig.h
> >> index 078cbd2ba651..de7f30f99af3 100644
> >> --- a/tools/bootconfig/include/linux/bootconfig.h
> >> +++ b/tools/bootconfig/include/linux/bootconfig.h
> >> @@ -4,4 +4,8 @@
> >>
> >> #include "../../../../include/linux/bootconfig.h"
> >>
> >> +#ifndef fallthrough
> >> +# define fallthrough
> >> +#endif
> >> +
> >> #endif
> >>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity and top posting.

--
Masami Hiramatsu <mhiramat@kernel.org>