From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2655C433ED for ; Fri, 21 May 2021 05:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C0AD613B4 for ; Fri, 21 May 2021 05:09:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239421AbhEUFLM (ORCPT ); Fri, 21 May 2021 01:11:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238672AbhEUFLK (ORCPT ); Fri, 21 May 2021 01:11:10 -0400 Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [IPv6:2a01:37:3000::53df:4ef0:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2388CC061574 for ; Thu, 20 May 2021 22:09:48 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 3976D2800B3CA; Fri, 21 May 2021 07:09:46 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 2CCCD1EDD; Fri, 21 May 2021 07:09:46 +0200 (CEST) Date: Fri, 21 May 2021 07:09:46 +0200 From: Lukas Wunner To: Saravana Kannan Cc: Mark Brown , kernel-team@android.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v2] spi: Don't have controller clean up spi device before driver unbind Message-ID: <20210521050946.GA26930@wunner.de> References: <20210505164734.175546-1-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210505164734.175546-1-saravanak@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 05, 2021 at 09:47:34AM -0700, Saravana Kannan wrote: > When a spi device is unregistered and triggers a driver unbind, the > driver might need to access the spi device. So, don't have the > controller clean up the spi device before the driver is unbound. Clean > up the spi device after the driver is unbound. > > Fixes: c7299fea6769 ("spi: Fix spi device unregister flow") > Reported-by: Lukas Wunner > Signed-off-by: Saravana Kannan > --- > > v1->v2: > - Made the clean up more symmetric. > > Lukas, > > Can you test this one your end to make sure you don't have issues > anymore? Tested-by: Lukas Wunner My apologies for the delay, yesterday I was finally able to set up a RasPi in my home office and test the patch. I'm not seeing any issues when unloading/reloading the SPI controller module, so this LGTM. Thanks, Lukas