From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A57C8C433ED for ; Fri, 21 May 2021 12:11:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EE9061073 for ; Fri, 21 May 2021 12:11:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232523AbhEUMNG (ORCPT ); Fri, 21 May 2021 08:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbhEUMM5 (ORCPT ); Fri, 21 May 2021 08:12:57 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39442C061763 for ; Fri, 21 May 2021 05:11:32 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id n2so20935262wrm.0 for ; Fri, 21 May 2021 05:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i3PtvIn3e83BJKazxoRmqSdndVRiSDgFlBve83mzSb0=; b=lWo0CnDeza1lg1y/wl0wstJvMhHfAumf114y9xzRjwZTnbUeMXVE0HNqg24Uerkn/j jG2Cx8StiDpVjcp2++hDyzfPQ9XoAGSPQP1npC720ODVBqWDMR9FxsRc1vI1PbBC5p9i CIYLPCk1UZ3oGnnLmUSVAdWoUA1Xui6x/MY/Rd1HZzrH/F3RSoAGAIif4tNRyXDzRXv7 cOjqCOum6LSTCJ4y0GDGCv97FqImIFPn1taGtcelrXNxuojOn2JTWXrh07dDN1xADLGq VqC5EQYKkSqWeJ0VC6LG6j0NuYeIYYpET3cXlffeE5D7wVLHs0aazL4EdrKfzAI6LdyS V+Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i3PtvIn3e83BJKazxoRmqSdndVRiSDgFlBve83mzSb0=; b=SLY97lhgMjRAUwV4FDAk6IaxaZMgkc14tjx0ChP1ThzOLs/LZMviUUxH+5lrdDnwiv G/U/X9w/mPCRDIUFrOCrYMSpqNCQQ0LIfbpClpJ52ysEiWQp5x9cDBRIWZ9z5ERIfWG7 f4Ekv9VO0RzXQhtBeIXe6swo7aotUTFHmEkYBWrTL9N53ACGfn5/IlEk3q38fJ6D+Wio dD7XMWzXwo98V1Ow/qDAPYzVLWcI1JAYqG5pAVJeq3tVs4f9VZqeRvDFm+ZiJfOL0SSB ZAV/3bGQydzRWpwRToMjv2jUIYj2ePHCsUKnXkNmumFjV/N4HC7DZg16NCrFBMggeFTN L6Gw== X-Gm-Message-State: AOAM533UtBMACSGvw4GVUzL5IjQEvLaozn/tJoSSfmN2dZGaCBLjaELR u+TCgm0HNiG6rVEGA+oDnl8= X-Google-Smtp-Source: ABdhPJwrgnwHqggWQ/pppvxseMU9ZskSzS2UEsOWZW6JmOTj/pMlpOtg3UuT78DMFju3VNdIhAveMA== X-Received: by 2002:adf:f10c:: with SMTP id r12mr9416310wro.26.1621599090895; Fri, 21 May 2021 05:11:30 -0700 (PDT) Received: from oliver-Z170M-D3H.cuni.cz ([2001:718:1e03:5128:e010:8b67:85b8:dc89]) by smtp.gmail.com with ESMTPSA id c64sm3339401wma.15.2021.05.21.05.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 05:11:30 -0700 (PDT) From: glittao@gmail.com To: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, faiyazm@codeaurora.org, Oliver Glitta Subject: [RFC 2/3] mm/slub: sort objects in cache by frequency of stack trace Date: Fri, 21 May 2021 14:11:26 +0200 Message-Id: <20210521121127.24653-2-glittao@gmail.com> X-Mailer: git-send-email 2.31.1.272.g89b43f80a5 In-Reply-To: <20210521121127.24653-1-glittao@gmail.com> References: <20210521121127.24653-1-glittao@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Glitta Sort objects in slub cache by the frequency of stack trace used in object location in alloc_calls and free_calls implementation in debugfs. Most frequently used stack traces will be the first. Signed-off-by: Oliver Glitta --- mm/slub.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index d5ed6ed7d68b..247983d647cd 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include @@ -5893,6 +5894,17 @@ static void *slab_debugfs_next(struct seq_file *seq, void *v, loff_t *ppos) return NULL; } +static int cmp_loc_by_count(const void *a, const void *b, const void *data) +{ + struct location *loc1 = (struct location *)a; + struct location *loc2 = (struct location *)b; + + if (loc1->count > loc2->count) + return -1; + else + return 1; +} + static void *slab_debugfs_start(struct seq_file *seq, loff_t *ppos) { struct kmem_cache_node *n; @@ -5944,6 +5956,11 @@ static void *slab_debugfs_start(struct seq_file *seq, loff_t *ppos) process_slab(&t, s, page, alloc); spin_unlock_irqrestore(&n->list_lock, flags); } + + /* Sort locations by count */ + sort_r(t.loc, t.count, sizeof(struct location), + cmp_loc_by_count, NULL, NULL); + } if (*ppos < t.count) { -- 2.31.1.272.g89b43f80a5