Re: [PATCH] ALSA: usb-audio: fix control-request direction

Takashi Iwai
2021-05-21T14:20:05Z

On Fri, 21 May 2021 15:37:42 +0200,
Johan Hovold wrote:
>
> The direction of the pipe argument must match the request-type direction
> bit or control requests may fail depending on the host-controller-driver
> implementation.
>
> Fix the UAC2_CS_CUR request which erroneously used usb_sndctrlpipe().
>
> Fixes: 93db51d06b32 ("ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3")
> Cc: stable@vger.kernel.org # 5.10
> Signed-off-by: Johan Hovold <johan@kernel.org>

Thanks, applied now.

> ---
>
> There's a related bug in sound/usb/mixer_scarlett_gen2.c, which
> Geoffrey reported and said he was preparing a patch for here:
>
> https://lore.kernel.org/r/20210520180819.GA95348@m.b4.vu

Yes, I'm going to apply them now, too.

Takashi