Re: [PATCH v5 1/8] dt-bindings: input: touchscreen: iqs626a: chnage node name to pass validation

Jeff LaBundy
2021-05-23T03:09:59Z

Hi Oleksij and Rob,

I disagree with this patch; the device is neither a touchscreen nor
does the example include any touchscreen properties. The end result
is confusing.

On Fri, May 21, 2021 at 12:08:30PM -0500, Rob Herring wrote:
> On Fri, 21 May 2021 06:45:18 +0200, Oleksij Rempel wrote:
> > Change node name from iqs626a -> touchscreen to pass dt_binding_check.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>

What is the failure returned by dt_binding_check? Is it because of
the reference to touchscreen.yaml? If so, I'd rather we update the
tool instead of appease it.

This device leverages the touchscreen helpers for axis swapping or
inversion in 'trackpad' mode, which any input device is free to do
starting with 5.13.

Kind regards,
Jeff LaBundy