Re: [PATCH v2 13/14] soc/tegra: pmc: Add core power domain

Ulf Hansson
2021-05-24T17:05:22Z

On Mon, 24 May 2021 at 01:13, Dmitry Osipenko <digetx@gmail.com> wrote:
>
> NVIDIA Tegra SoCs have multiple power domains, each domain corresponds
> to an external SoC power rail. Core power domain covers vast majority of
> hardware blocks within a Tegra SoC. The voltage of a power domain should
> be set to a level which satisfies all devices within the power domain.
> Add support for the core power domain which controls voltage state of the
> domain. This allows us to support system-wide DVFS on Tegra20-210 SoCs.
> The PMC powergate domains now are sub-domains of the core domain, this
> requires device-tree updating, older DTBs are unaffected.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
> Tested-by: Paul Fertser <fercerpav@gmail.com> # PAZ00 T20
> Tested-by: Nicolas Chauvet <kwizart@gmail.com> # PAZ00 T20 and TK1 T124
> Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

[...]

> +
> +static int tegra_pmc_core_pd_add(struct tegra_pmc *pmc, struct device_node *np)
> +{
> + static struct lock_class_key tegra_core_domain_lock_class;
> + struct generic_pm_domain *genpd;
> + const char *rname = "core";
> + int err;
> +
> + genpd = devm_kzalloc(pmc->dev, sizeof(*genpd), GFP_KERNEL);
> + if (!genpd)
> + return -ENOMEM;
> +
> + genpd->name = np->name;
> + genpd->set_performance_state = tegra_pmc_core_pd_set_performance_state;
> + genpd->opp_to_performance_state = tegra_pmc_core_pd_opp_to_performance_state;
> +
> + err = devm_pm_opp_set_regulators(pmc->dev, &rname, 1);
> + if (err)
> + return dev_err_probe(pmc->dev, err,
> + "failed to set core OPP regulator\n");
> +
> + err = pm_genpd_init(genpd, NULL, false);
> + if (err) {
> + dev_err(pmc->dev, "failed to init core genpd: %d\n", err);
> + return err;
> + }
> +
> + /*
> + * We have a "PMC pwrgate -> Core" hierarchy of the power domains
> + * where PMC needs to resume and change performance (voltage) of the
> + * Core domain from the PMC GENPD on/off callbacks, hence we need
> + * to annotate the lock in order to remove confusion from the
> + * lockdep checker when a nested access happens.
> + */

Can you elaborate a bit more on this?

Are you saying that when the child domain (PMC pwrgate) gets powered
off, you want to drop its aggregated votes it may hold for the
performance state, as otherwise it may affect the parent domain (core
domain)?

I guess this would be a valid scenario to optimize for, especially if
you have more than one child domain of the core power domain, right?

If you have only one child domain, would it be sufficient to assign
->power_on|off() callbacks for the core domain and deal with the
performance stare votes from there instead?

> + lockdep_set_class(&genpd->mlock, &tegra_core_domain_lock_class);
> +
> + err = of_genpd_add_provider_simple(np, genpd);
> + if (err) {
> + dev_err(pmc->dev, "failed to add core genpd: %d\n", err);
> + goto remove_genpd;
> + }
> +
> + return 0;
> +
> +remove_genpd:
> + pm_genpd_remove(genpd);
> +
> + return err;
> +}

[...]

> +static void tegra_pmc_sync_state(struct device *dev)
> +{
> + int err;
> +
> + pmc->core_domain_state_synced = true;
> +
> + /* this is a no-op if core regulator isn't used */
> + mutex_lock(&pmc->powergates_lock);
> + err = dev_pm_opp_sync_regulators(dev);
> + mutex_unlock(&pmc->powergates_lock);
> +
> + if (err)
> + dev_err(dev, "failed to sync regulators: %d\n", err);
> +}
> +

Nitpick.

Would you mind splitting the "sync_state" thingy out into a separate
patch on top of $subject patch?

I think it would be nice, especially since it shares a function via
include/soc/tegra/common.h - that would make it clear to what part
that belongs to.

> static struct platform_driver tegra_pmc_driver = {
> .driver = {
> .name = "tegra-pmc",
> @@ -3680,6 +3822,7 @@ static struct platform_driver tegra_pmc_driver = {
> #if defined(CONFIG_PM_SLEEP) && defined(CONFIG_ARM)
> .pm = &tegra_pmc_pm_ops,
> #endif
> + .sync_state = tegra_pmc_sync_state,
> },
> .probe = tegra_pmc_probe,
> };
> diff --git a/include/soc/tegra/common.h b/include/soc/tegra/common.h
> index af41ad80ec21..135a6956a18c 100644
> --- a/include/soc/tegra/common.h
> +++ b/include/soc/tegra/common.h
> @@ -23,6 +23,8 @@ struct tegra_core_opp_params {
> #ifdef CONFIG_ARCH_TEGRA
> bool soc_is_tegra(void);
>
> +bool tegra_soc_core_domain_state_synced(void);
> +
> int devm_tegra_core_dev_init_opp_table(struct device *dev,
> struct tegra_core_opp_params *params);
> #else
> @@ -31,6 +33,11 @@ static inline bool soc_is_tegra(void)
> return false;
> }
>
> +static inline bool tegra_soc_core_domain_state_synced(void)
> +{
> + return false;
> +}
> +
> static inline int
> devm_tegra_core_dev_init_opp_table(struct device *dev,
> struct tegra_core_opp_params *params)

Kind regards
Uffe