From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D04C2B9F8 for ; Mon, 24 May 2021 14:48:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2FCC61439 for ; Mon, 24 May 2021 14:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233544AbhEXOuY (ORCPT ); Mon, 24 May 2021 10:50:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:54958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233172AbhEXOs1 (ORCPT ); Mon, 24 May 2021 10:48:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2FDA6613BF; Mon, 24 May 2021 14:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621867619; bh=vDmDR8rBz5cxhgymzBsBDhzNOahKdYK7bBgaf5bEXag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Os3vwjUJVVW98bqN9pa5qIHSUy8z0efpNoyEUTdKL42xglO42Vc6WPsmuvwXrd9DZ zvi6ZG1qz8uo3PlguIYADHm0vRb2V8pXGONa/AasWTufdLsmyHfbFrnj20LKijzD2N 5e2NwQ72HaXiDX1QCM63AloDEYfjUv1SGP/FL6Tc4WsqOajxZjW9H5FCwY47XGWO+x VtRTro5wUd/BRYtYNh7PjcPPyncUcc6VIdjQiQo76lozAnhgAmIMn+6IMg3qcIu7F1 A/1ffyJQlU53pb3CV+cw/nAOX0UytE0N7E7yv4q96RnkarCCmrAANJd0mNp/Ekn0a4 7+AuLPCkTSU6w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Kangjie Lu , Mark Brown , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.12 29/63] Revert "ASoC: rt5645: fix a NULL pointer dereference" Date: Mon, 24 May 2021 10:45:46 -0400 Message-Id: <20210524144620.2497249-29-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210524144620.2497249-1-sashal@kernel.org> References: <20210524144620.2497249-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit 1e0ce84215dbfd6065872e5d3755352da34f198b ] This reverts commit 51dd97d1df5fb9ac58b9b358e63e67b530f6ae21. Because of recent interactions with developers from @umn.edu, all commits from them have been recently re-reviewed to ensure if they were correct or not. Upon review, this commit was found to be incorrect for the reasons below, so it must be reverted. It will be fixed up "correctly" in a later kernel change. Lots of things seem to be still allocated here and must be properly cleaned up if an error happens here. Cc: Kangjie Lu Cc: Mark Brown Link: https://lore.kernel.org/r/20210503115736.2104747-55-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- sound/soc/codecs/rt5645.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 63a7e052eaa0..ab06133a85da 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3407,9 +3407,6 @@ static int rt5645_probe(struct snd_soc_component *component) RT5645_HWEQ_NUM, sizeof(struct rt5645_eq_param_s), GFP_KERNEL); - if (!rt5645->eq_param) - return -ENOMEM; - return 0; } -- 2.30.2