From: nizamhaider786@gmail.com
To: lkundrak@v3.sk
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Nijam Haider <nizamhaider786@gmail.com>
Subject: [PATCH v3 2/2] char: pcmcia: scr24x_cs: Fix redundant fops
Date: Tue, 25 May 2021 03:22:02 +0530 [thread overview]
Message-ID: <20210524215202.495-2-nizamhaider786@gmail.com> (raw)
In-Reply-To: <20210524215202.495-1-nizamhaider786@gmail.com>
From: Nijam Haider <nizamhaider786@gmail.com>
Removed redundant fops assignment, which was already done in cdev_init()
Signed-off-by: Nijam Haider <nizamhaider786@gmail.com>
---
V2 -> V3: Added changelog and squishing the subject and description
V1 -> V2: Spliting the patch into two
---
drivers/char/pcmcia/scr24x_cs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
index b48e79356611..c41e9bf3a3f1 100644
--- a/drivers/char/pcmcia/scr24x_cs.c
+++ b/drivers/char/pcmcia/scr24x_cs.c
@@ -266,7 +266,6 @@ static int scr24x_probe(struct pcmcia_device *link)
cdev_init(&dev->c_dev, &scr24x_fops);
dev->c_dev.owner = THIS_MODULE;
- dev->c_dev.ops = &scr24x_fops;
ret = cdev_add(&dev->c_dev, MKDEV(MAJOR(scr24x_devt), dev->devno), 1);
if (ret < 0)
goto err;
--
2.7.4
next prev parent reply other threads:[~2021-05-24 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 21:52 [PATCH v3 1/2] char: pcmcia: scr24x_cs: Fix failure handling of device_create() nizamhaider786
2021-05-24 21:52 ` nizamhaider786 [this message]
2021-05-27 12:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524215202.495-2-nizamhaider786@gmail.com \
--to=nizamhaider786@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox