From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH] nvme: Use NN for max_namespaces if MNAN is zero
Date: Tue, 25 May 2021 09:22:34 +0200 [thread overview]
Message-ID: <20210525072234.GA13966@lst.de> (raw)
In-Reply-To: <20210525071259.j5g7koxqad7hwpkp@beryllium.lan>
On Tue, May 25, 2021 at 09:12:59AM +0200, Daniel Wagner wrote:
> On Mon, May 24, 2021 at 09:37:03AM +0200, Christoph Hellwig wrote:
> > I think we should add a sanity check for that and reject the broken
> > controller if that is not the case rather than working around it.
>
> Alright. I understood from the spec, that in the non ANA case the NN
> field should still be case though?
For non-ANA MNAN doesn't have to be set indeed. But we also don't use
the value at all either.
next prev parent reply other threads:[~2021-05-25 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 14:47 [PATCH] nvme: Use NN for max_namespaces if MNAN is zero Daniel Wagner
2021-05-21 14:53 ` Daniel Wagner
2021-05-21 15:27 ` Keith Busch
2021-05-21 20:19 ` Sagi Grimberg
2021-05-24 7:37 ` Christoph Hellwig
2021-05-25 7:12 ` Daniel Wagner
2021-05-25 7:22 ` Christoph Hellwig [this message]
2021-05-25 7:52 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525072234.GA13966@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox