Re: [PATCH v5 2/2] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

Eli Billauer
2021-05-28T09:09:26Z

On 27/05/21 15:12, Greg KH wrote:
>> diff --git a/drivers/char/xillybus/Makefile b/drivers/char/xillybus/Makefile
>> > index 591615264591..16f31d03209d 100644
>> > --- a/drivers/char/xillybus/Makefile
>> > +++ b/drivers/char/xillybus/Makefile
>> > @@ -7,3 +7,4 @@ obj-$(CONFIG_XILLYBUS_CLASS) += xillybus_class.o
>> > obj-$(CONFIG_XILLYBUS) += xillybus_core.o
>> > obj-$(CONFIG_XILLYBUS_PCIE) += xillybus_pcie.o
>> > obj-$(CONFIG_XILLYBUS_OF) += xillybus_of.o
>> > +obj-$(CONFIG_XILLYUSB) += xillyusb.o
>>
> This doesn't quite work.
>
> Even if I have not selected CONFIG_XILLYBUS I get asked aboug
> CONFIG_XILLYUSB.
The symbol tree is:

XILLYBUS_CLASS --+-- XILLYBUS --+-- XILLYBUS_PCIE
| |
| +-- XILLYBUS_OF
|
+-- XILLYUSB

Hence not selecting CONFIG_XILLYBUS doesn't eliminate CONFIG_XILLYUSB.
The behavior you described is correct: CONFIG_XILLYUSB doesn't depend on
CONFIG_XILLYBUS.

> And if I say 'm' to CONFIG_XILLYUSB, nothing gets
> built.
>
>
Sorry, my bad. The directory is currently invoked based upon
CONFIG_XILLYBUS, which was correct before, but now it should be
CONFIG_XILLYBUS_CLASS. I'll submit a patch fixing that promptly.

Plus another patch removing MODULE_VERSION() from all C files, per your
earlier comment.

Thanks and regards,
Eli