Re: [PATCH 00/24] Rid W=1 warnings from USB

Peter Chen
2021-05-27T01:46:47Z

On 21-05-26 14:00:13, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.

For chipidea and cdns3 parts:

Acked-by: Peter Chen <peter.chen@kernel.org>

Peter
>
> Lee Jones (24):
> usb: cdns3: core: Fix a couple of incorrectly documented function
> names
> usb: dwc2: platform: Provide function name for
> 'dwc2_check_core_version()'
> usb: common: ulpi: Add leading underscores for function name
> '__ulpi_register_driver()'
> usb: cdns3: cdns3-plat: Fix incorrect naming of function
> 'cdns3_plat_remove()'
> usb: dwc2: params: Fix naming of 'dwc2_get_hwparams()' in the docs
> usb: isp1760: isp1760-udc: Provide missing description for 'udc' param
> usb: cdns3: cdns3-gadget: Fix a bunch of kernel-doc related formatting
> issues
> usb: cdns3: cdns3-ti: File headers are not good candidates for
> kernel-doc
> usb: cdns3: cdns3-ep0: Fix a few kernel-doc formatting issues
> usb: cdns3: cdns3-imx: File headers are not good candidates for
> kernel-doc
> usb: dwc2: hcd_queue: Fix typeo in function name
> 'dwc2_hs_pmap_unschedule()'
> usb: dwc2: pci: Fix possible copy/paste issue
> usb: chipidea: core: Fix incorrectly documented function
> 'ci_usb_phy_exit()'
> usb: chipidea: otg: Fix formatting and missing documentation issues
> usb: dwc2: gadget: Repair 'dwc2_hsotg_core_init_disconnected()'s
> documentation
> usb: chipidea: udc: Fix incorrectly documented function
> 'hw_port_is_high_speed()'
> usb: host: xhci: Remove unused variable 'len'
> usb: gadget: udc: pxa27x_udc: Fix documentation for
> 'pxa27x_udc_start()'
> usb: gadget: udc: udc-xilinx: Place correct function names into the
> headers
> usb: cdns3: cdns3-gadget: Provide correct function naming for
> '__cdns3_gadget_ep_queue()'
> usb: host: xhci: Move array of structs from the stack onto the heap
> usb: host: xhci: Document xhci_get_endpoint_index()'s 'desc' param
> usb: cdns3: cdnsp-gadget: Provide function name for
> 'cdnsp_find_next_ext_cap()'
> usb: typec: ucsi: Fix copy/paste issue for 'ucsi_set_drvdata()'
>
> drivers/usb/cdns3/cdns3-ep0.c | 6 ++---
> drivers/usb/cdns3/cdns3-gadget.c | 34 ++++++++++++++---------------
> drivers/usb/cdns3/cdns3-imx.c | 2 +-
> drivers/usb/cdns3/cdns3-plat.c | 2 +-
> drivers/usb/cdns3/cdns3-ti.c | 2 +-
> drivers/usb/cdns3/cdnsp-gadget.c | 3 ++-
> drivers/usb/cdns3/core.c | 4 ++--
> drivers/usb/chipidea/core.c | 2 +-
> drivers/usb/chipidea/otg.c | 9 ++++----
> drivers/usb/chipidea/udc.c | 2 +-
> drivers/usb/common/ulpi.c | 2 +-
> drivers/usb/dwc2/gadget.c | 2 +-
> drivers/usb/dwc2/hcd_queue.c | 2 +-
> drivers/usb/dwc2/params.c | 4 ++--
> drivers/usb/dwc2/pci.c | 2 +-
> drivers/usb/dwc2/platform.c | 2 +-
> drivers/usb/gadget/udc/pxa27x_udc.c | 2 +-
> drivers/usb/gadget/udc/udc-xilinx.c | 4 ++--
> drivers/usb/host/xhci.c | 19 +++++++++++-----
> drivers/usb/isp1760/isp1760-udc.c | 1 +
> drivers/usb/typec/ucsi/ucsi.c | 2 +-
> 21 files changed, 59 insertions(+), 49 deletions(-)
>
> Cc: Aswath Govindraju <a-govindraju@ti.com>
> Cc: Ben Dooks <ben@simtec.co.uk>
> Cc: Daniel Mack <daniel@zonque.org>
> Cc: David Lopo <dlopo@chipidea.mips.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-usb@vger.kernel.org
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Cc: Matthijs Kooijman <matthijs@stdin.nl>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Minas Harutyunyan <hminas@synopsys.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Pawel Jez <pjez@cadence.com>
> Cc: Pawel Laszczak <pawell@cadence.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Peter Chen <peter.chen@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: Rui Miguel Silva <rui.silva@linaro.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> --
> 2.31.1
>

--

Thanks,
Peter Chen