From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] tracing: Remove redundant variable ret
Date: Fri, 28 May 2021 02:14:49 +0900 [thread overview]
Message-ID: <20210527171449.GA145584@hyeyoo> (raw)
This variable saves return value of event_hist_trigger_func,
but it's never read. So it's redundant.
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
---
kernel/trace/trace_events_hist.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index c1abd63f1d6c..414f2727d7a7 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -5225,12 +5225,11 @@ static void unregister_field_var_hists(struct hist_trigger_data *hist_data)
struct trace_event_file *file;
unsigned int i;
char *cmd;
- int ret;
for (i = 0; i < hist_data->n_field_var_hists; i++) {
file = hist_data->field_var_hists[i]->hist_data->event_file;
cmd = hist_data->field_var_hists[i]->cmd;
- ret = event_hist_trigger_func(&trigger_hist_cmd, file,
+ event_hist_trigger_func(&trigger_hist_cmd, file,
"!hist", "hist", cmd);
}
}
--
2.25.1
next reply other threads:[~2021-05-27 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 17:14 Hyeonggon Yoo [this message]
2021-05-29 2:22 ` [PATCH] tracing: Remove redundant variable ret Steven Rostedt
2021-05-29 5:47 ` Hyeonggon Yoo
2021-05-29 6:00 ` [PATCH v2] tracing: Add WARN_ON_ONCE when returned value is negative Hyeonggon Yoo
2021-05-29 6:14 ` Hyeonggon Yoo
2021-05-29 6:14 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527171449.GA145584@hyeyoo \
--to=42.hyeyoo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox