From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014ACC4708C for ; Fri, 28 May 2021 09:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D964160724 for ; Fri, 28 May 2021 09:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234497AbhE1J6L (ORCPT ); Fri, 28 May 2021 05:58:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236279AbhE1J57 (ORCPT ); Fri, 28 May 2021 05:57:59 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 670A0C061760 for ; Fri, 28 May 2021 02:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=a2uo9vSb+aABBmUmlUH2DE45CphhEqNlicwhzWks7yM=; b=ZjWKoO+erAmoYwbpbAIT3ml63 wqI1VaOI9eHzxA5U3h6obbE6yhtbM/M4o9Qxwal4K+RghNN/cPy8O31/58pZkg1iO/x+fGCfEUTTg OFCKGscvYPWDndPrKrpIGgz/Odt5rrk0tU+e6ywDtgyVSInRyC35bIK/SGqUS82vCUuIXBu1/aqbe s0OK7SE2+FvvxXIuaUEWZFAmAGX1+7sHSmv40yl3H9IFoIpi8RCCfK+cvRpVdS+NVli9y8dXdtKVi gMfCYfy2VgfrpG/vUMf4xkmmJqiymK3cTAGo8jHpyVcN79PnZWqQbeG3DLvAqZFjBEVqSSCjoyHgs h2ZyyI8Zw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44434) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmZDn-0008DM-RE; Fri, 28 May 2021 10:56:03 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lmZDi-0004cX-8U; Fri, 28 May 2021 10:55:58 +0100 Date: Fri, 28 May 2021 10:55:58 +0100 From: "Russell King (Oracle)" To: Nicolas Pitre Cc: Linus Walleij , Yanfei Xu , Mike Rapoport , Ard Biesheuvel , Andrew Morton , Hailong liu , Tian Tao , Linux ARM , linux-kernel Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start Message-ID: <20210528095558.GN30436@shell.armlinux.org.uk> References: <20210518120633.GW12395@shell.armlinux.org.uk> <8q526rs-853n-5q80-r9pn-87sso759r13@syhkavp.arg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8q526rs-853n-5q80-r9pn-87sso759r13@syhkavp.arg> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 06:32:43PM -0400, Nicolas Pitre wrote: > On Tue, 18 May 2021, Nicolas Pitre wrote: > > > On Wed, 19 May 2021, Linus Walleij wrote: > > > > > On Tue, May 18, 2021 at 2:15 PM Russell King (Oracle) > > > wrote: > > > > > > > Change the current vmalloc_min, which is supposed to be the lowest > > > > address of vmalloc space including the VMALLOC_OFFSET, to vmalloc_start > > > > which does not include VMALLOC_OFFSET. > > > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > Reviewed-by: Linus Walleij > > > > > > > +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20); > > > > > > When I first read this it took me some time to figure out what was > > > going on here, so if you have time, please fold in a comment > > > with some explanation of that (240 << 20) thing, in some blog > > > post I described it as "an interesting way to write 0x0f000000" > > > but I suppose commit 0536bdf33faf chose this way for a > > > specific reason? (Paging Nico if he can explain it.) > > > > That's an alternative (and deprecated) way to write MB(240). > > And it seems that MB() isn't globally defined either. Oh well. I could add a patch on the end of the series changing it to 240 * SZ_1M which will likely be clearer. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!