Re: [PATCH v6 05/20] vfio: mdev: common lib code for setting up Interrupt Message Store

Thomas Gleixner
2021-05-31T14:22:16Z

On Fri, May 21 2021 at 17:19, Dave Jiang wrote:
> Add common helper code to setup IMS once the MSI domain has been
> setup by the device driver. The main helper function is
> mdev_ims_set_msix_trigger() that is called by the VFIO ioctl
> VFIO_DEVICE_SET_IRQS. The function deals with the setup and
> teardown of emulated and IMS backed eventfd that gets exported
> to the guest kernel via VFIO as MSIX vectors.

So this talks about IMS, but the functionality is all named mdev_msix*
and mdev_irqs*. Confused.

> +/*
> + * Mediate device IMS library code

Mediated?

> +static int mdev_msix_set_vector_signal(struct mdev_irq *mdev_irq, int vector, int fd)
> +{
> + int rc, irq;
> + struct mdev_device *mdev = irq_to_mdev(mdev_irq);
> + struct mdev_irq_entry *entry;
> + struct device *dev = &mdev->dev;
> + struct eventfd_ctx *trigger;
> + char *name;
> + bool pasid_en;
> + u32 auxval;
> +
> + if (vector < 0 || vector >= mdev_irq->num)
> + return -EINVAL;
> +
> + entry = &mdev_irq->irq_entries[vector];
> +
> + if (entry->ims)
> + irq = dev_msi_irq_vector(dev, entry->ims_id);
> + else
> + irq = 0;

I have no idea what this does. Comments are overrated...

Aside of that dev_msi_irq_vector() seems to be a gross misnomer. AFAICT
it retrieves the Linux interrupt number and not some vector.

> + pasid_en = mdev_irq->pasid != INVALID_IOASID ? true : false;
> +
> + /* IMS and invalid pasid is not a valid configuration */
> + if (entry->ims && !pasid_en)
> + return -EINVAL;

Why is this not validated already?

> + if (entry->trigger) {
> + if (irq) {
> + irq_bypass_unregister_producer(&entry->producer);
> + free_irq(irq, entry->trigger);
> + if (pasid_en) {
> + auxval = ims_ctrl_pasid_aux(0, false);
> + irq_set_auxdata(irq, IMS_AUXDATA_CONTROL_WORD, auxval);

Why can't this be done in the irq chip when the interrupt is torn down?
Just because the irq chip driver, which is thankfully not merged yet,
has been implemented that way?

I did this aux dance because someone explained to me that this has to be
handled seperately and has to be changed independent of all the
interrupt setup and whatever. But looking at the actual usage now that's
clearly not the case.

What's the exact order of all this? I assume so:

1) mdev_irqs_init()
2) mdev_irqs_set_pasid()
3) mdev_set_msix_trigger()

Right? See below.

> +}
> +EXPORT_SYMBOL_GPL(mdev_irqs_set_pasid);

> + if (fd < 0)
> + return 0;
> +
> + name = kasprintf(GFP_KERNEL, "vfio-mdev-irq[%d](%s)", vector, dev_name(dev));
> + if (!name)
> + return -ENOMEM;
> +
> + trigger = eventfd_ctx_fdget(fd);
> + if (IS_ERR(trigger)) {
> + kfree(name);
> + return PTR_ERR(trigger);
> + }
> +
> + entry->name = name;
> + entry->trigger = trigger;
> +
> + if (!irq)
> + return 0;

These exit conditions are completely confusing.

> + if (pasid_en) {
> + auxval = ims_ctrl_pasid_aux(mdev_irq->pasid, true);
> + rc = irq_set_auxdata(irq, IMS_AUXDATA_CONTROL_WORD, auxval);
> + if (rc < 0)
> + goto err;

Again. This can be handled in the interrupt chip when the interrupt is
set up through request_irq().

> +static int mdev_msix_enable(struct mdev_irq *mdev_irq, int nvec)
> +{
> + struct mdev_device *mdev = irq_to_mdev(mdev_irq);
> + struct device *dev;
> + int rc;
> +
> + if (nvec != mdev_irq->num)
> + return -EINVAL;
> +
> + if (mdev_irq->ims_num) {
> + dev = &mdev->dev;
> + rc = msi_domain_alloc_irqs(dev_get_msi_domain(dev), dev, mdev_irq->ims_num);

The allocation of the interrupts happens _after_ PASID has been
set and PASID is per device, right?

So the obvious place to store PASID is in struct device because the
device pointer is for one stored in the msi entry descriptor and it is
also handed down to the irq domain allocation function. So this can be
checked at allocation time already.

What's unclear to me is under which circumstances does the IMS interrupt
require a PASID.

1) Always
2) Use case dependent

Thanks,

tglx