From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A771FC4708F for ; Sat, 29 May 2021 20:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83C4D6117A for ; Sat, 29 May 2021 20:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbhE2UEQ (ORCPT ); Sat, 29 May 2021 16:04:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbhE2UEC (ORCPT ); Sat, 29 May 2021 16:04:02 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BE60C061761 for ; Sat, 29 May 2021 13:02:25 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id 69-20020a9d0a4b0000b02902ed42f141e1so7005089otg.2 for ; Sat, 29 May 2021 13:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4FphgqFErW0u2I7OqG/s+zxrWEtrI/oXO1p258v43Ag=; b=n55O3oUL67115DySLu3bR8N2ipzKbkp5AMEbL2zGQSzsU2SCz9NnacVuqYt0s1Tm2Y kai018ghAOhIUh9fM7QmYEaD0kiyJCq+L6NbXJeO9Lx8uTA4lSkQ3VZA+2w+iuTG0iN5 iXT4lfqH8Vg0luqwzPwaig6BeR7vT2Ro7wNYOnX4SHD/1JzhHtjzKvX1Dy865g1wyTxk 6aVrHCMQ2wJwwOFnRfvNtws8yDIDNcvxJIcyVuPUMTfRjDaCJRU72M2RCkO1huZBKnAj RsGbffTt/dBLg7aLs4RE43cUWeY3aDLDdpXXsz7mGeJ6D2bV0+OPKc5tgAyexCgXBUNJ 7O0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4FphgqFErW0u2I7OqG/s+zxrWEtrI/oXO1p258v43Ag=; b=QTgxJ0dk7qct666bJgSmyRoVmqfbvitz68um1K6i+OrFOy+p+8tWLhf/HQklBn5f7d V6b+JYrQXsn9jiPvGArDiw8rpMfbuDwMp9gPVo9HpqfcgaJHl8zAz7D2AqCdeGk3prQ/ v3CDzUPj7XFhepqXiL9CpRhHaoY395F8Ch0MQ2WdhzB+NDPjk+DAkngzRZAreuglRBk6 aKSgB5axCwfsCV0J8YSJC3Qb2lISlaMLTSXuq6iLbTxOnj1x15FjBYOe5SwCeFRS6YOf Ma8UZs+3WcZ6zpTLh3uGNQHM/sRkEwHFcVT3+CA7eAd93H5rUuBCdGtVABMV4kXRtMT3 wvUg== X-Gm-Message-State: AOAM532gBmDFgQ8M+FNmxTyTkoz0FyoT9CeDcwdzNopCIOkvl83//Q7Q 2gZkDjurSS2x8DwZqdN5gjEKFrdRtYnNdA== X-Google-Smtp-Source: ABdhPJwKqSkcrt+/Kaqpljm8bdOV6cmPOZzibdwiReoPfuhes/76eHVa+3H3kphSNcvWwAA1TTEfNw== X-Received: by 2002:a9d:8c2:: with SMTP id 60mr12168888otf.217.1622318544504; Sat, 29 May 2021 13:02:24 -0700 (PDT) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t39sm1868064ooi.42.2021.05.29.13.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 May 2021 13:02:24 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: Jim Cromie Subject: [RFC PATCH v6 11/34] dyndbg: accept null site in dynamic_emit_prefix Date: Sat, 29 May 2021 14:00:06 -0600 Message-Id: <20210529200029.205306-12-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210529200029.205306-1-jim.cromie@gmail.com> References: <20210529200029.205306-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2 prints use site->member, protect them with if site. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index b2fd7c181bd5..868f56edf831 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -630,15 +630,19 @@ static char *__dynamic_emit_prefix(const struct _ddebug *dp, char *buf) task_pid_vnr(current)); } pos_after_tid = pos; - if (dp->flags & _DPRINTK_FLAGS_INCL_MODNAME) - pos += snprintf(buf + pos, remaining(pos), "%s:", - desc->modname); - if (dp->flags & _DPRINTK_FLAGS_INCL_FUNCNAME) - pos += snprintf(buf + pos, remaining(pos), "%s:", - desc->function); + + if (desc) { + if (dp->flags & _DPRINTK_FLAGS_INCL_MODNAME) + pos += snprintf(buf + pos, remaining(pos), "%s:", + desc->modname); + if (dp->flags & _DPRINTK_FLAGS_INCL_FUNCNAME) + pos += snprintf(buf + pos, remaining(pos), "%s:", + desc->function); + } if (dp->flags & _DPRINTK_FLAGS_INCL_LINENO) pos += snprintf(buf + pos, remaining(pos), "%d:", dp->lineno); + if (pos - pos_after_tid) pos += snprintf(buf + pos, remaining(pos), " "); if (pos >= PREFIX_SIZE) -- 2.31.1