From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCC4C4708F for ; Mon, 31 May 2021 09:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F3EB610C8 for ; Mon, 31 May 2021 09:39:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231177AbhEaJky (ORCPT ); Mon, 31 May 2021 05:40:54 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:57902 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230423AbhEaJkx (ORCPT ); Mon, 31 May 2021 05:40:53 -0400 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14V9atMN002531; Mon, 31 May 2021 09:38:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=I25HnzG1ls/ymOqV+uapF3ZRxaUxv6ftkIkApeUNKmw=; b=jJGUfjjpUAgRP5G4GQjFNKvKMFpiLIrPpSpgEWmPPvvcl8f+N/kN/cKtYH7UoHCwH/p6 dRo/GF2LKnMmKG/PBBlcv60YD5+FW/BUXgGZsUH9AwVsaYbxAWAERlToL5OWSMmh4g/F 29YekBYJ/eMmbDZTKCEYK8KFqHn1GHmvG0bKgwhkTt/tq1KscBNOFpGREhVCs3/enlA6 E9hi7/SYKtL8o/wyOlKDP2wXHEBJg91G/C6u5TafTbIdUimfR1DKt/G5Fp19g10bwRT0 aLH6lROOkQekyOAsDizQkXamPOFnE4yM8cSqJCC6WSnhRmaLq9mDp6dDcio8eu6jS+1E gw== Received: from oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 38vng404qq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 May 2021 09:38:28 +0000 Received: from userp3020.oracle.com (userp3020.oracle.com [127.0.0.1]) by pps.podrdrct (8.16.0.36/8.16.0.36) with SMTP id 14V9cRvT174687; Mon, 31 May 2021 09:38:27 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3020.oracle.com with ESMTP id 38uycq8h95-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 May 2021 09:38:27 +0000 Received: from userp3020.oracle.com (userp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 14V9cRDC174676; Mon, 31 May 2021 09:38:27 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 38uycq8h8q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 May 2021 09:38:27 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 14V9cP1f006251; Mon, 31 May 2021 09:38:25 GMT Received: from kadam (/41.212.42.34) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 May 2021 02:38:24 -0700 Date: Mon, 31 May 2021 12:38:17 +0300 From: Dan Carpenter To: Dongliang Mu Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel , syzbot+08a7d8b51ea048a74ffb@syzkaller.appspotmail.com Subject: Re: [PATCH] ALSA: control led: fix memory leak in snd_ctl_led_register Message-ID: <20210531093817.GY24442@kadam> References: <20210528140500.GS24442@kadam> <20210531044022.GU24442@kadam> <20210531070337.GV24442@kadam> <20210531084613.GX24442@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-ORIG-GUID: 4LX8YaSfZEV5qL5xelSpwLTF4oM-N9LQ X-Proofpoint-GUID: 4LX8YaSfZEV5qL5xelSpwLTF4oM-N9LQ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 31, 2021 at 05:10:49PM +0800, Dongliang Mu wrote: > Hi Dan, > > I wonder if we shall split the current patch into two patches, one > patch for each memory leak. It is better to satisfy the rule - "one > patch only fixes one issue". > > We should absolutely fix all these memory leaks. But one patch for two > different bugs with different objects and different paths is not very > suitable. > I would just send one patch, because I only see it as one bug. But you do what you think is best. regards, dan carpenter