Re: [PATCH 4.4 35/54] ALSA: sb8: Add a comment note regarding an unused pointer

Pavel Machek
2021-05-31T20:36:45Z

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

Hi!

> [ Upstream commit a28591f61b60fac820c6de59826ffa710e5e314e ]
>
> The field "fm_res" of "struct snd_sb8" is never used/dereferenced
> throughout the sb8.c code. Therefore there is no need for any null value
> check after the "request_region()".
>
> Add a comment note to make developers know about this and prevent any
> "NULL check" patches on this part of code.
>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
> Link: https://lore.kernel.org/r/20210503115736.2104747-36-gregkh@linuxfoundation.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

This simply adds a comment... As I'm pretty sure anyone trying to
"fix" this will try that on mainline, it is even very useful comment.

That's something our documentation says we don't do in stable. I'd
prefer it not to be in.

Best regards,
Pavel

> +++ b/sound/isa/sb/sb8.c
> @@ -109,7 +109,11 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev)
> acard = card->private_data;
> card->private_free = snd_sb8_free;
>
> - /* block the 0x388 port to avoid PnP conflicts */
> + /*
> + * Block the 0x388 port to avoid PnP conflicts.
> + * No need to check this value after request_region,
> + * as we never do anything with it.
> + */
> acard->fm_res = request_region(0x388, 4, "SoundBlaster FM");
>
> if (port[dev] != SNDRV_AUTO_PORT) {

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]