Re: [PATCH 02/15] leds: leds-gpio-register: Supply description for param 'id'

Uwe Kleine-König
2021-05-28T10:35:45Z

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

Hey Lee,

On Fri, May 28, 2021 at 10:55:31AM +0100, Lee Jones wrote:
> On Fri, 28 May 2021, Uwe Kleine-König wrote:
> > On Fri, May 28, 2021 at 10:06:16AM +0100, Lee Jones wrote:
> > > diff --git a/drivers/leds/leds-gpio-register.c b/drivers/leds/leds-gpio-register.c
> > > index b9187e71e0cf2..de3f12c2b80d7 100644
> > > --- a/drivers/leds/leds-gpio-register.c
> > > +++ b/drivers/leds/leds-gpio-register.c
> > > @@ -11,6 +11,7 @@
> > > /**
> > > * gpio_led_register_device - register a gpio-led device
> > > * @pdata: the platform data used for the new device
> > > + * @id: platform ID
> > > *
> >
> > Given that id is the first parameter and pdata the second I suggest to
> > swap the order here and describe id first.
>
> That's super picky.
>
> I can do it as a follow-up patch if you *really* care about it.

I'd say introducing the one-line description for id now in the "wrong"
location and then reordering as a followup is ridiculus. But having said
that: I don't care at all.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]