From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Ruiqi Gong <gongruiqi1@huawei.com>
Cc: Wang Weiyang <wangweiyang2@huawei.com>,
linux-mips@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] MIPS: pm-cps: Make '__pcpu_scope_cps_cpu_state' static
Date: Tue, 1 Jun 2021 11:29:50 +0200 [thread overview]
Message-ID: <20210601092949.GA6961@alpha.franken.de> (raw)
In-Reply-To: <20210528070437.5780-1-gongruiqi1@huawei.com>
On Fri, May 28, 2021 at 03:04:37PM +0800, Ruiqi Gong wrote:
> Mark the per-CPU definition of cps_cpu_state as static to fix the following
> sparse tool complain:
>
> arch/mips/kernel/pm-cps.c:66:1: warning:
> symbol '__pcpu_scope_cps_cpu_state' was not declared. Should it be static?
did you compile/link a kernel with this patch ? I doubt that since there
is a refernec to this symbol in arch/mips/kernel/cps-vec.S.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-06-01 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 7:04 [PATCH -next] MIPS: pm-cps: Make '__pcpu_scope_cps_cpu_state' static Ruiqi Gong
2021-06-01 9:29 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601092949.GA6961@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=gongruiqi1@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=wangweiyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox