From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: [PATCH v1 1/2] soc/tegra: pmc: Don't sync core domain if it's missing in device-tree
Date: Wed, 2 Jun 2021 02:10:02 +0300 [thread overview]
Message-ID: <20210601231003.9845-2-digetx@gmail.com> (raw)
In-Reply-To: <20210601231003.9845-1-digetx@gmail.com>
Older device-trees don't have core domain node. In this case we shouldn't
mark the domain as synced, allowing to begin core voltage scaling.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/soc/tegra/pmc.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index d8eee285fd58..d317532130c3 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -431,6 +431,7 @@ struct tegra_pmc {
struct notifier_block clk_nb;
bool core_domain_state_synced;
+ bool core_domain_registered;
};
static struct tegra_pmc *pmc = &(struct tegra_pmc) {
@@ -1382,6 +1383,8 @@ static int tegra_pmc_core_pd_add(struct tegra_pmc *pmc, struct device_node *np)
goto remove_genpd;
}
+ pmc->core_domain_registered = true;
+
return 0;
remove_genpd:
@@ -3798,6 +3801,14 @@ static void tegra_pmc_sync_state(struct device *dev)
{
int err;
+ /*
+ * Older device-trees don't have core PD, and thus, there are
+ * no dependencies that will block the state syncing. We shouldn't
+ * mark the domain as synced in this case.
+ */
+ if (!pmc->core_domain_registered)
+ return;
+
pmc->core_domain_state_synced = true;
/* this is a no-op if core regulator isn't used */
--
2.30.2
next prev parent reply other threads:[~2021-06-01 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 23:10 [PATCH v1 0/2] NVIDIA Tegra core power domain follow up Dmitry Osipenko
2021-06-01 23:10 ` Dmitry Osipenko [this message]
2021-06-01 23:10 ` [PATCH v1 2/2] soc/tegra: pmc: Remove usage of lockdep_set_class() Dmitry Osipenko
2021-06-02 7:38 ` [PATCH v1 0/2] NVIDIA Tegra core power domain follow up Ulf Hansson
2021-06-02 9:10 ` Thierry Reding
2021-06-02 10:00 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601231003.9845-2-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).