From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: [PATCH v1 2/2] soc/tegra: pmc: Remove usage of lockdep_set_class()
Date: Wed, 2 Jun 2021 02:10:03 +0300 [thread overview]
Message-ID: <20210601231003.9845-3-digetx@gmail.com> (raw)
In-Reply-To: <20210601231003.9845-1-digetx@gmail.com>
The lockdep_set_class() will become necessary only if we will have a
nested toggling of core / PMC power domains that will happen if we will
add RPM and OPP support to Tegra CCF driver. Ulf Hansson has concerns
about whether this is the best approach. He suggested to remove the
lockdep class annotation until we will agree on how the OPP support of
clocks should be implemented, hence remove it for now.
Suggested-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/soc/tegra/pmc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index d317532130c3..ea62f84d1c8b 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -1344,7 +1344,6 @@ tegra_pmc_core_pd_opp_to_performance_state(struct generic_pm_domain *genpd,
static int tegra_pmc_core_pd_add(struct tegra_pmc *pmc, struct device_node *np)
{
- static struct lock_class_key tegra_core_domain_lock_class;
struct generic_pm_domain *genpd;
const char *rname = "core";
int err;
@@ -1368,15 +1367,6 @@ static int tegra_pmc_core_pd_add(struct tegra_pmc *pmc, struct device_node *np)
return err;
}
- /*
- * We have a "PMC pwrgate -> Core" hierarchy of the power domains
- * where PMC needs to resume and change performance (voltage) of the
- * Core domain from the PMC GENPD on/off callbacks, hence we need
- * to annotate the lock in order to remove confusion from the
- * lockdep checker when a nested access happens.
- */
- lockdep_set_class(&genpd->mlock, &tegra_core_domain_lock_class);
-
err = of_genpd_add_provider_simple(np, genpd);
if (err) {
dev_err(pmc->dev, "failed to add core genpd: %d\n", err);
--
2.30.2
next prev parent reply other threads:[~2021-06-01 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 23:10 [PATCH v1 0/2] NVIDIA Tegra core power domain follow up Dmitry Osipenko
2021-06-01 23:10 ` [PATCH v1 1/2] soc/tegra: pmc: Don't sync core domain if it's missing in device-tree Dmitry Osipenko
2021-06-01 23:10 ` Dmitry Osipenko [this message]
2021-06-02 7:38 ` [PATCH v1 0/2] NVIDIA Tegra core power domain follow up Ulf Hansson
2021-06-02 9:10 ` Thierry Reding
2021-06-02 10:00 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601231003.9845-3-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).