From: Kees Cook <keescook@chromium.org>
To: Yejune Deng <yejune.deng@gmail.com>
Cc: tglx@linutronix.de, peterz@infradead.org, frederic@kernel.org,
mingo@kernel.org, dave@stgolabs.net,
linux-kernel@vger.kernel.org, Yejune Deng <yejunedeng@gmail.com>
Subject: Re: [PATCH] softirq: Remove the unnecessary CONFIG_TRACE_IRQFLAGS
Date: Wed, 2 Jun 2021 10:53:08 -0700 [thread overview]
Message-ID: <202106021051.0AF942F9@keescook> (raw)
In-Reply-To: <1622619282-12077-1-git-send-email-yejunedeng@gmail.com>
On Wed, Jun 02, 2021 at 03:34:42PM +0800, Yejune Deng wrote:
> The local_irq_enable() and local_irq_disable() had two definitions that
> include CONFIG_TRACE_IRQFLAGS or not.
Hm, this has a behavioral change. Current code only does tracing and
raw_local_irq_disable/enable when CONFIG_TRACE_IRQFLAGS. This change
causes it to always do raw_local_irq_disable/enable. Which is the right
behavior?
-Kees
>
> Signed-off-by: Yejune Deng <yejunedeng@gmail.com>
> ---
> kernel/softirq.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index 4992853..a81d804 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -362,9 +362,7 @@ void __local_bh_enable_ip(unsigned long ip, unsigned int cnt)
> {
> WARN_ON_ONCE(in_irq());
> lockdep_assert_irqs_enabled();
> -#ifdef CONFIG_TRACE_IRQFLAGS
> local_irq_disable();
> -#endif
> /*
> * Are softirqs going to be turned on now:
> */
> @@ -385,9 +383,7 @@ void __local_bh_enable_ip(unsigned long ip, unsigned int cnt)
> }
>
> preempt_count_dec();
> -#ifdef CONFIG_TRACE_IRQFLAGS
> local_irq_enable();
> -#endif
> preempt_check_resched();
> }
> EXPORT_SYMBOL(__local_bh_enable_ip);
> --
> 2.7.4
>
--
Kees Cook
next prev parent reply other threads:[~2021-06-02 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 7:34 [PATCH] softirq: Remove the unnecessary CONFIG_TRACE_IRQFLAGS Yejune Deng
2021-06-02 17:53 ` Kees Cook [this message]
2021-08-10 13:59 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106021051.0AF942F9@keescook \
--to=keescook@chromium.org \
--cc=dave@stgolabs.net \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=yejune.deng@gmail.com \
--cc=yejunedeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox